Add pigz to trimgalore #7169
Merged
Add pigz to trimgalore #7169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmundmiller
force-pushed
the
trimgalore-pigz
branch
from
786b4f8 to
461a57e
Compare
|
Huh, I went back and added a check, and it was in the image anyway, but the Bioconda packages don't include it. Guess I didn't try the old singularity image locally it was the docker image 🤷🏻♂️ It Should work now. |
SPPearce
reviewed
Dec 6, 2024
SPPearce
reviewed
Dec 6, 2024
SPPearce
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one shouldn't be controversial. It's documented that using pigz speeds up trimgalore. In the DSL2 transition the requirement got dropped because it was in mega environment.yml in methylseq, and atac-seq.
Closes nf-core/atacseq#394
https://github.com/FelixKrueger/TrimGalore/blob/master/CHANGELOG.md#version-060-release-on-1-mar-2019