Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

input_sample code path does not explicitly sort input image filenames #28

Open
jmuhlich opened this issue Apr 23, 2024 · 1 comment
Open
Assignees
Labels
bug Something isn't working

Comments

@jmuhlich
Copy link
Member

Description of the bug

When using input_sample, the image directory files are collected via Groovy's File.eachFileRecurse which does not yield the results in any sorted order. The results must be collected and then sorted explicitly by filename. In addition it's probably better not to recurse and require all files are provided at the top level, as user expectations will vary on how files in subdirectories should be sorted relative to each other. This is as simple as replacing eachFileRecurse with eachFile. Or eachFileMatch could be used to perform the .ome.tif filename match as well.

Command used and terminal output

No response

Relevant files

No response

System information

No response

@jmuhlich jmuhlich added the bug Something isn't working label Apr 23, 2024
@RobJY RobJY self-assigned this Apr 26, 2024
@RobJY
Copy link
Contributor

RobJY commented Apr 29, 2024

I have a fix for this in my repo in branch issue_28 using eachFileMatch and an explicit sort as you mentioned. I'll make a PR for it once PR #29 has been merged.

RobJY added a commit to RobJY/mcmicro-nf-core that referenced this issue May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants