Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Missing QBR Data #114

Open
2 tasks done
mawi510 opened this issue Sep 26, 2024 · 2 comments
Open
2 tasks done

[BUG] Missing QBR Data #114

mawi510 opened this issue Sep 26, 2024 · 2 comments

Comments

@mawi510
Copy link

mawi510 commented Sep 26, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Have you installed the latest development version of the package(s) in question?

  • I have installed the latest development version of the package.

If this is a data issue, have you tried clearing your nflverse cache?

I am not using an nflverse R package (nflreadr, nflfastR) to access this data.

What version of the package do you have?

0.3.3

Describe the bug

import_qbr doesn't return any data for the 2024 (current) season.

Reprex

import nfl_data_py as nfl
qbr = nfl.import_qbr([2024], 'nfl', 'weekly')
qbr.head()


The above returns an empty dataframe

Expected Behavior

I expected a dataframe similar to what the following would return, but for the current season:

import nfl_data_py as nfl
qbr = nfl.import_qbr([2023], 'nfl', 'weekly')
qbr.head()

nflverse_sitrep

NA

Screenshots

No response

Additional context

No response

@alecglen
Copy link
Collaborator

alecglen commented Sep 26, 2024

The data source for this method is outdated, it should point to the espn_data feed.

@mawi510 here's a workaround until I can get that fixed.

import pandas as pd

url = "https://github.com/nflverse/nflverse-data/releases/download/espn_data/qbr_week_level.parquet"
qbr = pd.read_parquet(url).loc[lambda x: x.season == 2024].reset_index(drop=True)

@mawi510
Copy link
Author

mawi510 commented Sep 28, 2024

@alecglen No worries, really appreciate the workaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants