Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUILD_SHARED_LIBS does not guard add_library (glew SHARED ...) #420

Open
VA-GS opened this issue Oct 3, 2024 · 2 comments
Open

BUILD_SHARED_LIBS does not guard add_library (glew SHARED ...) #420

VA-GS opened this issue Oct 3, 2024 · 2 comments

Comments

@VA-GS
Copy link

VA-GS commented Oct 3, 2024

Hello, is it expected that with BUILD_SHARED_LIBS being false, the glew shared library is still created ? I hit the issue using the conan package as they use the all target but I set some flags on my dependencies that are correct only for static linking and expected glew_s only to be built.

@nigels-com
Copy link
Owner

It looks like the CMakeLists.txt is building both static and shared (suprise!) but only installing one or the other.
I agree that it would be more conventional to have both static and shared optional, and only build what's asked for.

@nigels-com
Copy link
Owner

It's possible that the intention here is to closely match how the GNUmake build is arranged.
But I agree that it seems defying the usual cmake convention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants