diff --git a/notifier.go b/notifier.go index 72960549..09dcf514 100644 --- a/notifier.go +++ b/notifier.go @@ -1,14 +1,9 @@ package notify -// Notifier defines the behavior for notification services. It implements Send and AddReciever +// Notifier defines the behavior for notification services. // -// The Send command simply sends a message string to the internal destination Notifier. -// E.g for telegram it sends the message to the specified group chat. -// -// The AddReceivers takes one or many strings and -// adds these to the list of destinations for receiving messages -// e.g. slack channels, telegram chats, email addresses. +// The Send function simply sends a subject and a message string to the internal destination Notifier. +// E.g for telegram.Telegram it sends the message to the specified group chat. type Notifier interface { Send(string, string) error - AddReceivers(...string) } diff --git a/notify.go b/notify.go index 489e357d..692524ab 100644 --- a/notify.go +++ b/notify.go @@ -18,7 +18,7 @@ type Notify struct { // ErrSendNotification signals that the notifier failed to send a notification. var ErrSendNotification = errors.New("send notification") -// New returns a new instance of Notify. Defaulting to being not disabled +// New returns a new instance of Notify. Defaulting to being not disabled. func New() *Notify { notifier := &Notify{ Disabled: defaultDisabled, diff --git a/send.go b/send.go index 66e8a9d8..0a3ac26f 100644 --- a/send.go +++ b/send.go @@ -5,7 +5,7 @@ import ( "golang.org/x/sync/errgroup" ) -// Send calls the underlying notification services to send the given message to their respective endpoints. +// Send calls the underlying notification services to send the given subject and message to their respective endpoints. func (n Notify) Send(subject, message string) error { if n.Disabled { return nil diff --git a/service/telegram/telegram.go b/service/telegram/telegram.go index 4c4528ff..0fa44846 100644 --- a/service/telegram/telegram.go +++ b/service/telegram/telegram.go @@ -1,8 +1,6 @@ package telegram import ( - "strconv" - tgbotapi "github.com/go-telegram-bot-api/telegram-bot-api" "github.com/pkg/errors" ) @@ -34,13 +32,8 @@ func New(apiToken string) (*Telegram, error) { // AddReceivers takes Telegram chat IDs and adds them to the internal chat ID list. The Send method will send // a given message to all those chats. -func (t *Telegram) AddReceivers(chatIDs ...string) { - for _, v := range chatIDs { - chatID, err := strconv.ParseInt(v, 10, 64) - if err == nil { - t.chatIDs = append(t.chatIDs, chatID) - } - } +func (t *Telegram) AddReceivers(chatIDs ...int64) { + t.chatIDs = append(t.chatIDs, chatIDs...) } // Send takes a message subject and a message body and sends them to all previously set chats. Message body supports diff --git a/use.go b/use.go index 18a8f9e8..71c54e49 100644 --- a/use.go +++ b/use.go @@ -1,14 +1,13 @@ package notify -// useService adds a given service to the notifiers services list. +// useService adds a given service to the Notifier's services list. func (n *Notify) useService(service Notifier) { - if service == nil { - return + if service != nil { + n.notifiers = append(n.notifiers, service) } - n.notifiers = append(n.notifiers, service) } -// UseServices adds the given service(s) to the notifiers services list. +// UseServices adds the given service(s) to the Notifier's services list. func (n *Notify) UseServices(service ...Notifier) { for _, s := range service { n.useService(s)