Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow SSMSE to work with SS3.30.21 #215

Open
k-doering-NOAA opened this issue Jun 5, 2024 · 9 comments
Open

allow SSMSE to work with SS3.30.21 #215

k-doering-NOAA opened this issue Jun 5, 2024 · 9 comments
Assignees
Labels

Comments

@k-doering-NOAA
Copy link
Collaborator

@e-perl-NOAA is working on making SSMSE compatible with SS3.30.21. This is because a user needs a feature that is only available in 3.30.21 and newer.

SSMSE will continue to work and will be distributed with the 3.30.18 binaries. However, users will be able to swap in the 3.30.21 exes instead, if they would like, and should expect SSMSE to work once this issue is completed.

@e-perl-NOAA feel free to add to this/edit if I missed something or got something wrong!

@MauroMardones
Copy link

i wondering to know if do you have some news about this issue. maybe i pressing a little bit.
Takk

@e-perl-NOAA
Copy link
Collaborator

I made progress on this awhile ago but reached a road block with one of the SSMSE functions that I had to pass on to @k-doering-NOAA to see if she could sort out the issue. I hope 🙏 that will be the last step in getting SSMSE working with SS3 v 3.30.21.

@MauroMardones
Copy link

Cool. i guess is a tricky issue. thanks anyway for the progress. I will be with an eye on.

@MauroMardones
Copy link

MauroMardones commented Jul 3, 2024

im trying to run the example with 3.30.18 v but this message appear when run
cod_1_path <- file.path(run_SSMSE_dir, "cod_SR_BH_steep_1")
"sudo: a terminal is required to read the password; either use the -S option to read from standard input or configure an askpass helper
sudo: a password is required"

what mean?

@e-perl-NOAA
Copy link
Collaborator

I ran the example in the README.md on both my local windows machine and on a linux machine using GitHub codespaces but I didn't run into that message. Maybe it's a folder permission issue on your computer.

@MauroMardones
Copy link

Could it be an issue with the executable? Do I need to manually place it in a specific directory or the function generates it?

@e-perl-NOAA
Copy link
Collaborator

SSMSE uses the executable that's in the package.
You could try changing the permissions of the executable in the package with

sudo chmod a+x path-to-executable-in-ssmse

too see if that does anything.

@e-perl-NOAA
Copy link
Collaborator

@k-doering-NOAA could you help with this issue before you go on leave? There is just one test (test-interim) that seems to not pass and I'm at a loss as to why. See failed action here with details on failed testthat.

@k-doering-NOAA
Copy link
Collaborator Author

I think 06048c5 fixes the interim tests (passes locally for me with an older r4ss version). The failing ghactions are due to #216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants