-
Notifications
You must be signed in to change notification settings - Fork 29.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc, child_process: add esm snippets #53616
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
child_process
Issues and PRs related to the child_process subsystem.
doc
Issues and PRs related to the documentations.
labels
Jun 27, 2024
atlowChemi
reviewed
Jun 28, 2024
atlowChemi
reviewed
Jun 28, 2024
RedYetiDev
added
the
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
label
Aug 19, 2024
@atlowChemi could you re-review? |
atlowChemi
approved these changes
Aug 29, 2024
Co-authored-by: Chemi Atlow <chemi@atlow.co.il>
Trott
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
and removed
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
labels
Sep 4, 2024
atlowChemi
approved these changes
Sep 5, 2024
atlowChemi
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Sep 5, 2024
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Sep 5, 2024
Landed in 0debdac |
aduh95
pushed a commit
that referenced
this pull request
Sep 12, 2024
PR-URL: #53616 Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Merged
targos
pushed a commit
that referenced
this pull request
Sep 22, 2024
PR-URL: #53616 Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
targos
pushed a commit
that referenced
this pull request
Sep 26, 2024
PR-URL: #53616 Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
child_process
Issues and PRs related to the child_process subsystem.
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
doc
Issues and PRs related to the documentations.
review wanted
PRs that need reviews.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds ESM snippets to the documentation for
node:child_process
.In addition to this, some snippets were modified for readability (
message
instead ofm
, etc)