Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emoji search returns no results for single letter queries #295

Open
dumptyd opened this issue Nov 2, 2022 · 3 comments
Open

Emoji search returns no results for single letter queries #295

dumptyd opened this issue Nov 2, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@dumptyd
Copy link

dumptyd commented Nov 2, 2022

This is a necessary feature when implementing something like github's emoji autocomplete dropdown. If there are performance concerns, you can keep this disabled by default and expose a way to modify MIN_SEARCH_TEXT_LENGTH.

@nolanlawson
Copy link
Owner

Yeah, I can see why you might want this to be configurable. Although it will bloat the size of the database, although I don't know by how much. In any case, it will need to be globally configured since it affects how data is written to IDB.

@nolanlawson nolanlawson added the enhancement New feature or request label Nov 8, 2022
abdullah4a added a commit to abdullah4a/emoji-picker-element that referenced this issue Dec 16, 2022
@abdullah4a
Copy link

@nolanlawson, I've fixed this issue as setting up min length 0 and changed the condition in picker if this change were needed then review PR here

@nolanlawson
Copy link
Owner

This is a necessary feature when implementing something like github's emoji autocomplete dropdown.

BTW it looks like GitHub's emoji autocomplete works with single-letter queries because it only renders a max of 5 emoji. emoji-picker-element does not have any kind of limit for the results, nor does it do any lazy/virtual rendering, hence the perf issue described here: #298 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants