Improve the Notifications Service

nova-framework · May 11, 2018 · 13b1c27 · 13b1c27
1 parent 2333ee8
commit 13b1c27
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/src/Foundation/Application.php b/src/Foundation/Application.php
@@ -41,7 +41,7 @@ class Application extends Container implements ResponsePreparerInterface
      *
      * @var string
      */
-    const VERSION = '4.0.50';
+    const VERSION = '4.0.52';
 
     /**
      * Indicates if the application has "booted".

diff --git a/src/Notifications/ChannelManager.php b/src/Notifications/ChannelManager.php
@@ -167,16 +167,10 @@ protected function queueToNotifiable($notifiable, $id, $notification, $channel)
     {
         $notification->id = $id;
 
-        $connection = isset($notification->connection) ? $notification->connection : null;
-
-        $queue = isset($notification->queue) ? $notification->queue : null;
-
-        $delay = isset($notification->delay) ? $notification->delay : null;
-
         $job = with(new SendQueuedNotifications($notifiable, $notification, array($channel)))
-            ->onConnection($connection)
-            ->onQueue($queue)
-            ->delay($delay);
+            ->onConnection($notification->connection)
+            ->onQueue($notification->queue)
+            ->delay($notification->delay);
 
         $this->bus->dispatch($job);
     }