Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#863] Placed Dependencies and Dependency Versions In TOML file #885

Open
wants to merge 28 commits into
base: main
Choose a base branch
from

Conversation

ThatSilentCoder
Copy link
Collaborator

@ThatSilentCoder ThatSilentCoder commented Nov 22, 2024

Description

Test Instructions:

  1. Run the ./gradlew clean --refresh-dependencies build command and verify that not only does this command pull all of the new dependencies but it also builds the entire application without any issues.
  2. Another way to confirm that these changes are good is by building an RPM and installing then running the HIRS-ACA service (building the RPM requires building and assembling all the artifacts and running the ACA service locally).

Summary Of Updates:

  • Upgraded Gradle from version 8.3 to version 8.11.1.
  • Moved repetitive tasks to the root build.gradle file.
  • Upgraded spring-framework-boot plugin from version 3.0.6 to version 3.0.13.
  • Upgraded spring-dependency-management plugin from version 1.1.0 to version 1.1.7.
  • Upgraded ospackage plugin from version 11.4.0 to version 11.10.0.
  • Upgraded spotbugs plugin from version 6.0.4 to version 6.0.13.
  • Upgraded gradle-jaxb plugin from version 5.1.0 to version 7.0.1.
  • Deleted unused dependencies and/or replaced dependencies that were already included in a bigger dependency (this was to ensure that we do not have any dependency mismatches).
  • Placed all dependencies and dependencies versions in a toml file. Click on the following link for more details on Version Cataloguing: Medium Article on Version Catalog and see the table below to see all the changes:

Dependencies Changes:

Name Old Version New Version Notes
org.apache.httpcomponents:httpclient - 4.5.14 Replacing transitive dependency in PCI dependency
org.bouncycastle:bcmail-jdk18on 1.77 1.79
commons-codec:commons-codec 1.15 1.17.1
commons-io:commons-io 2.11.0 2.18.0
org.apache.commons:commons-lang3 3.13.0 3.17.0
com.google.code.gson:gson 2.10.1 2.11.0
org.glassfish:jakarta.json 2.0.1
org.glassfish.jaxb:jaxb-runtime 4.0.5
com.google.guava:guava 33.3.1-jre
com.fasterxml.jackson.core:jackson-core 2.18.2
com.fasterxml.jackson.core:jackson-databind 2.18.2
jakarta.persistence:jakarta.persistence-api
org.glassfish.web:jakarta.servlet.jsp.jstl
jakarta.xml.bind:jakarta.xml.bind-api
org.jcommander:jcommander
org.projectlombok:lombok
org.mariadb.jdbc:mariadb-java-client
com.eclipsesource.minimal-json:minimal-json
com.github.marandus:pci-ids
com.google.protobuf:protobuf-java
org.slf4j:slf4j-simple
org.springframework.boot:spring-boot-starter-validation
org.springframework.boot:spring-boot-starter-web
org.springframework:spring-webmvc
org.springframework.retry:spring-retry
org.apache.tomcat.embed:tomcat-embed-jasper
org.testng:testn
org.hsqldb:hsqldb
org.springframework.boot:spring-boot-starter-test
com.github.spotbugs:spotbugs-annotations

Issues this PR addresses:

Closes #863

…urrently replacing dependencies listed in the build.gradle file with the ones referenced in the toml file
@ThatSilentCoder ThatSilentCoder linked an issue Nov 22, 2024 that may be closed by this pull request
…ndencies versions and the ci/cd pipeline in git. will update each depedency slowly to ensure that upgrades are down correctly.
…github's ci/cd is happy still with these set of changes.
…github's ci/cd is happy still with these set of changes (again)
…github's ci/cd is happy still with these set of changes (again) partIII
…is happy still with these set of changes (again)
…s happy still with these set of changes (again)
…guring what to do with the remaining vulnerabilities.
…, now figuring what to do with the remaining vulnerabilities.
@ThatSilentCoder ThatSilentCoder marked this pull request as ready for review December 19, 2024 13:34
…ability issues will be addressed in another PR. I've cut down vulnerabilities by quite a lot and I want to test the new OWASP plugin against the remaining vulnerabilities.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Place Dependencies in a Version Catalog file
1 participant