Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entry point to ritual initiation: Coordinator vs Subscription #278

Open
cygnusv opened this issue Jun 27, 2024 · 1 comment
Open

Entry point to ritual initiation: Coordinator vs Subscription #278

cygnusv opened this issue Jun 27, 2024 · 1 comment

Comments

@cygnusv
Copy link
Member

cygnusv commented Jun 27, 2024

I don't think there's really a correct vs incorrect way here, but IMO doing this from the Subscription will simplify some things, and conceptually makes the Coordinator more of a protocol-oriented contract (which is the idea, anyway).

If we change it to the Subscription:

  • Adopters will only interact with Subscriptions and AllowList contracts
  • Coordinator will only initiate a ritual if the Subscriptions was previously approved as a FeeModel, which is currently gatekeeped by the DAO Council
  • We can remove the initiator role from Coordinator, and even the whole concept of permissioned phase, since rituals can only be initiated from approved subscriptions.

If we leave it as is:

  • Adopters will pay to the Subscription, but interact with the Coordinator
  • DAO Council will have to separately approve the subscription as FeeModel and the adopter as initiator.
@cygnusv
Copy link
Member Author

cygnusv commented Jun 28, 2024

We agreed to:

  • Leave the entry point in the Coordinator
  • Remove the initiator role from Coordinator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant