Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<command> <subcommand> is inserted even when <command> is already typed #120

Open
EmilyGraceSeville7cf opened this issue May 1, 2023 · 8 comments
Labels
bug Something isn't working

Comments

@EmilyGraceSeville7cf
Copy link
Contributor

EmilyGraceSeville7cf commented May 1, 2023

  • Type into<space>
  • Press Ctrl+Space
  • Chose into int (or any other subcommand)
  • Get into into int, instead of into int

What can be done:

  • <command> should not be inserted when it's already written
  • <command> should not be shown in intellisence suggestion when it's already typed

Nu:

0.79.0

VS Code:

Version: 1.77.3
Commit: 704ed70d4fd1c6bd6342c436f1ede30d1cff4710
Date: 2023-04-12T09:16:52.732Z
Electron: 19.1.11
Chromium: 102.0.5005.196
Node.js: 16.14.2
V8: 10.2.154.26-electron.0
OS: Linux x64 5.15.0-71-generic
Sandboxed: No

OS:

Linux 22.04 Ubuntu
@fdncred fdncred added the bug Something isn't working label May 1, 2023
@fdncred
Copy link
Collaborator

fdncred commented May 1, 2023

ya, i think this is a bug. we may have to change nushell's complete functionality, or manipulate it's return on the typescript side.

@fdncred
Copy link
Collaborator

fdncred commented May 1, 2023

I can't reproduce this on Windows. That seems weird.

complete

@EmilyGraceSeville7cf
Copy link
Contributor Author

EmilyGraceSeville7cf commented May 1, 2023

I use Ubuntu 22.04 LTS (MATE desktop environment).

@fdncred
Copy link
Collaborator

fdncred commented May 1, 2023

I uploaded a gif, does it look like i'm doing what you described?

@EmilyGraceSeville7cf
Copy link
Contributor Author

To reproduce issue you should trigger autocomplete for into <something> when into<space> is written on the same line.

@fdncred
Copy link
Collaborator

fdncred commented May 2, 2023

I see what you mean. If you let the auto-completer launch itself, you get proper completions. If you ignore that prompt and ctrl+space yourself, you get into into completions.

I tested like this 'str' | int<auto_magic_complete> and it works fine but 'str | into <ctrl+space> I get into into whatever I chose. In the second form, where the problem is, i have to cancel the auto_magic_complete popup in order to make it fail.

@EmilyGraceSeville7cf
Copy link
Contributor Author

auto_magic_complete - where this setting can be found?

@fdncred
Copy link
Collaborator

fdncred commented May 2, 2023

auto_magic_complete - where this setting can be found?

LOL. I just mean that when i typed int, before i could get to the o in into, the completions pop up without me triggering them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants