Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Ionic & Capacitor plugins + Refactor & Update #1103

Merged
merged 18 commits into from
Sep 27, 2024

Conversation

edbzn
Copy link
Member

@edbzn edbzn commented Sep 25, 2024

Summary of changes:

  • This PR re-introduce Ionic & Capacitor plugins into the repository
  • Refactor the capacitor, ionic-angular, and ionic-react plugins
    • Drop the application generator in favor of a configuration generator that takes an existing app instead of generating a new one so we delegate application creation to the user and let him choose his configuration
    • Update generated Capacitor and Ionic versions

Copy link

nx-cloud bot commented Sep 25, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 81c9f77. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

@DominikPieper
Copy link
Member

@edbzn I would drop the generator for the react app as well. If we want to keep the ionic-angular and ionic-react packages I would keep the layer they bring in as small as possible. What do you think?

@DominikPieper
Copy link
Member

Looks good so far :-) you need to rebase once, we updated the Nx version to 19.4. No changes except the version.
See the discussion here: #1101
We want to go the next updates with all plugins reintegrated first

@edbzn
Copy link
Member Author

edbzn commented Sep 26, 2024

I just realized the new configuration generator for Angular should do more than what it does actually if we want proper configuration setup, here's what I think is missing:

  1. src/app/app.component.ts should be updated to include imports: [IonApp, IonRouterOutlet]
  2. src/app/app.component.html should be updated to include ion-app and ion-router-outlet
  3. src/theme/variables.scss should be created
  4. src/global.scss should be updated with proper ionic imports
  5. index.html should be updated with proper meta tags
  6. main.ts should be updated to include required ionic routing providers

@edbzn edbzn marked this pull request as ready for review September 27, 2024 08:27
@DominikPieper DominikPieper merged commit 89e3117 into main Sep 27, 2024
6 checks passed
@DominikPieper DominikPieper deleted the crystal-ionic-capacitor branch September 27, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants