-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Ionic & Capacitor plugins + Refactor & Update #1103
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 81c9f77. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targetsSent with 💌 from NxCloud. |
@edbzn I would drop the generator for the react app as well. If we want to keep the ionic-angular and ionic-react packages I would keep the layer they bring in as small as possible. What do you think? |
Looks good so far :-) you need to rebase once, we updated the Nx version to 19.4. No changes except the version. |
I just realized the new configuration generator for Angular should do more than what it does actually if we want proper configuration setup, here's what I think is missing:
|
Summary of changes:
capacitor
,ionic-angular
, andionic-react
pluginsapplication
generator in favor of aconfiguration
generator that takes an existing app instead of generating a new one so we delegate application creation to the user and let him choose his configuration