-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go/keymanager: Move master and ephemeral secrets code to extension #5544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peternose
force-pushed
the
peternose/trivial/ext-secrets
branch
2 times, most recently
from
January 30, 2024 09:35
8399f1a
to
a0c7f0d
Compare
peternose
requested review from
kostko,
peterjgilbert,
pro-wh and
ptrus
as code owners
January 30, 2024 10:10
peternose
force-pushed
the
peternose/trivial/ext-secrets
branch
4 times, most recently
from
January 31, 2024 02:16
73f8722
to
696f204
Compare
peternose
force-pushed
the
peternose/trivial/ext-secrets
branch
from
February 5, 2024 14:40
696f204
to
ed084f3
Compare
kostko
reviewed
Feb 7, 2024
peternose
force-pushed
the
peternose/trivial/ext-secrets
branch
from
February 7, 2024 09:41
ed084f3
to
5a18362
Compare
peternose
force-pushed
the
peternose/trivial/ext-secrets
branch
from
February 7, 2024 09:42
5a18362
to
0ac48f4
Compare
kostko
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having code for master and ephemeral secrets and code for churp in the same package is not transparent and introduces naming problems. This PR tries to refactor the code to achieve the following result:
Separating runtime suspension (suspendRuntimes
) and status generation (generateStatus
) on epoch change makes this PR consensus breaking.