Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/keymanager: Move master and ephemeral secrets code to extension #5544

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

peternose
Copy link
Contributor

@peternose peternose commented Jan 29, 2024

Having code for master and ephemeral secrets and code for churp in the same package is not transparent and introduces naming problems. This PR tries to refactor the code to achieve the following result:

// Backend is a key manager management implementation.
type Backend interface {
	Secrets() secrets.Backend

	Churp() churp.Backend
}

Separating runtime suspension (suspendRuntimes) and status generation (generateStatus) on epoch change makes this PR consensus breaking.

@peternose peternose force-pushed the peternose/trivial/ext-secrets branch 2 times, most recently from 8399f1a to a0c7f0d Compare January 30, 2024 09:35
@peternose peternose added the c:breaking/consensus Category: breaking consensus changes label Jan 30, 2024
@peternose peternose marked this pull request as ready for review January 30, 2024 10:10
@peternose peternose force-pushed the peternose/trivial/ext-secrets branch 4 times, most recently from 73f8722 to 696f204 Compare January 31, 2024 02:16
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 220 lines in your changes are missing coverage. Please review.

Comparison is base (191d346) 66.91% compared to head (696f204) 66.88%.
Report is 3 commits behind head on master.

❗ Current head 696f204 differs from pull request most recent head 0ac48f4. Consider uploading reports for the commit 0ac48f4 to get more accurate results

Files Patch % Lines
go/keymanager/secrets/grpc.go 53.33% 62 Missing and 22 partials ⚠️
...nsensus/cometbft/apps/keymanager/secrets/status.go 80.10% 26 Missing and 11 partials ⚠️
...sensus/cometbft/apps/keymanager/secrets/genesis.go 48.88% 16 Missing and 7 partials ⚠️
go/consensus/cometbft/keymanager/secrets/client.go 72.94% 16 Missing and 7 partials ⚠️
...o/consensus/cometbft/apps/keymanager/keymanager.go 65.38% 10 Missing and 8 partials ⚠️
.../consensus/cometbft/apps/keymanager/secrets/ext.go 70.58% 7 Missing and 3 partials ⚠️
.../consensus/cometbft/apps/keymanager/secrets/txs.go 64.70% 0 Missing and 6 partials ⚠️
go/keymanager/secrets/api.go 86.66% 5 Missing and 1 partial ⚠️
go/oasis-node/cmd/keymanager/keymanager.go 76.47% 3 Missing and 1 partial ⚠️
go/consensus/cometbft/apps/keymanager/genesis.go 60.00% 1 Missing and 1 partial ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5544      +/-   ##
==========================================
- Coverage   66.91%   66.88%   -0.04%     
==========================================
  Files         539      546       +7     
  Lines       56883    56976      +93     
==========================================
+ Hits        38064    38106      +42     
- Misses      14379    14420      +41     
- Partials     4440     4450      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peternose peternose force-pushed the peternose/trivial/ext-secrets branch from 696f204 to ed084f3 Compare February 5, 2024 14:40
@peternose peternose force-pushed the peternose/trivial/ext-secrets branch from ed084f3 to 5a18362 Compare February 7, 2024 09:41
@peternose peternose force-pushed the peternose/trivial/ext-secrets branch from 5a18362 to 0ac48f4 Compare February 7, 2024 09:42
@peternose peternose merged commit 93ecca9 into master Feb 7, 2024
4 checks passed
@peternose peternose deleted the peternose/trivial/ext-secrets branch February 7, 2024 10:11
@peternose peternose removed the c:breaking/consensus Category: breaking consensus changes label Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants