Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated Android/iOS images are different when generated from Mac vs. Windows #29

Open
muraziz opened this issue Aug 15, 2022 · 3 comments

Comments

@muraziz
Copy link

muraziz commented Aug 15, 2022

Hi!
We are two developers, one working on Mac and the other on Windows using this library for our RN project. Whenever one of us generates images using yarn react-native-vector-image generate and then the other runs the command to regenerate the same files, it creates a diff with file renames for all image files. It seems like the hash code part of generated image file names is different depending on whether generated on Mac or Windows.

Regarding that I have two questions.

  1. Is this expected?
  2. Any plans to make hash same?

While we can still use the lib (thanks for it!), it creates a lot of unnecessary diff changes during commits.
Thanks!

Screen Shot 2022-08-15 at 20 05 17

@baronha
Copy link

baronha commented Oct 20, 2022

same +1

@LinhLM23496
Copy link

Same +1

1 similar comment
@marcag3
Copy link

marcag3 commented Mar 13, 2023

Same +1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants