Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly incorrect order of operations in normalization #14

Closed
seann999 opened this issue Dec 20, 2023 · 1 comment
Closed

Possibly incorrect order of operations in normalization #14

seann999 opened this issue Dec 20, 2023 · 1 comment

Comments

@seann999
Copy link

seann999 commented Dec 20, 2023

I think it should be (x - mean) * std?

def normalize(self, data, metadata):
if self.normalization_type == "normal":
return (data / (metadata["std"] + 1e-8)) - metadata["mean"]

@kpertsch
Copy link
Collaborator

Ah good catch! Fixed it in #15 .
This should only affect scenarios in which you pass proprio to the policy (which needs to get normalized), eg the ALOHA finetune example.

kvablack pushed a commit that referenced this issue Dec 22, 2023
add proprio keys to normalization dump filename
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants