Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: Octokit.NotFoundExceptions should have a public parameterless constructor to allow for consumers to easily unit test #2973

Open
1 task done
EmilyThomasPCTY opened this issue Oct 1, 2024 · 0 comments
Labels
Type: Feature New feature or request

Comments

@EmilyThomasPCTY
Copy link

Describe the need

In order for a consumer to easily unit test when Octokit.NotFoundException is thrown
As a consumer
I want Octokit.NotFoundException to have a public parameterless constructor
So that I can easily use FakeItEasy to Throw<Octokit.NotFoundException>() for consumer testing purposes.

This could easily be abstracted out to apply to other models as well to make consumers' unit testing easier.

SDK Version

No response

API Version

No response

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@EmilyThomasPCTY EmilyThomasPCTY added Status: Triage This is being looked at and prioritized Type: Feature New feature or request labels Oct 1, 2024
@kfcampbell kfcampbell removed the Status: Triage This is being looked at and prioritized label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New feature or request
Projects
Status: 🔥 Backlog
Development

No branches or pull requests

2 participants