issue #113: review server layer

octopot · Oct 16, 2018 · 0c2069c · 0c2069c
1 parent ad598ab
commit 0c2069c
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 425 deletions.
diff --git a/pkg/server/contract.go b/pkg/server/contract.go
@@ -11,6 +11,6 @@ type Service interface {
 	// HandleGetV1 handles an input request.
 	// Deprecated: TODO issue#version3.0 use SchemaEditor and gRPC gateway instead
 	HandleGetV1(context.Context, v1.GetRequest) v1.GetResponse
-	// HandlePostV1 handles an input request.
-	HandlePostV1(context.Context, v1.PostRequest) v1.PostResponse
+	// HandleInput handles an input request.
+	HandleInput(context.Context, v1.PostRequest) v1.PostResponse
 }
diff --git a/pkg/server/grpc/mock_storage_test.go b/pkg/server/grpc/mock_storage_test.go
diff --git a/pkg/server/internal_test.go b/pkg/server/internal_test.go
diff --git a/pkg/server/mock_contract_test.go → pkg/server/mock_service_test.go b/pkg/server/mock_contract_test.go → pkg/server/mock_service_test.go
diff --git a/pkg/server/server.go b/pkg/server/server.go
@@ -54,7 +54,7 @@ func (s *Server) Input(rw http.ResponseWriter, req *http.Request) {
 		return
 	}
 	output := bytes.NewBuffer(make([]byte, 0, 1024))
-	resp := s.service.HandlePostV1(req.Context(), v1.PostRequest{
+	resp := s.service.HandleInput(req.Context(), v1.PostRequest{
 		Context: domain.InputContext{
 			Cookies: domain.FromCookies(req.Cookies()),
 			Headers: domain.FromHeaders(req.Header),