Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crashlytics non fatal bug cause of language + minor improvements #68

Merged
merged 7 commits into from
Mar 4, 2024

Conversation

odaridavid
Copy link
Owner

Related Issue

Description

How Can It Be Tested

Screenshots (If Applicable)

Additional Comments

Checklist

  • New tests were added/Existing Modified

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 0.00%. Comparing base (6a504e0) to head (502d727).

Files Patch % Lines
.../com/github/odaridavid/weatherapp/MainViewModel.kt 0.00% 6 Missing ⚠️
...aridavid/weatherapp/data/weather/remote/Mappers.kt 0.00% 4 Missing ⚠️
...therapp/data/settings/DefaultSettingsRepository.kt 0.00% 2 Missing ⚠️
...hub/odaridavid/weatherapp/ui/home/HomeViewModel.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           develop     #68   +/-   ##
=======================================
  Coverage     0.00%   0.00%           
=======================================
  Files           21      21           
  Lines          425     432    +7     
  Branches        38      39    +1     
=======================================
- Misses         425     432    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odaridavid odaridavid merged commit 82e6ca0 into develop Mar 4, 2024
6 checks passed
@odaridavid odaridavid deleted the fix-location-bugs branch March 4, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant