Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests are suspicable to rounding errors #151

Open
p-snft opened this issue Jul 2, 2020 · 2 comments
Open

Unit tests are suspicable to rounding errors #151

p-snft opened this issue Jul 2, 2020 · 2 comments

Comments

@p-snft
Copy link
Member

p-snft commented Jul 2, 2020

The unit tests for solar thermal use lp files that contain decimal representations of floating point numbers. The actual values seem to depend on the used platform, so the unit test worked for me but failed at Travis. (I now fixed it to fail at my computer, see 7dd83ea)

@c-moeller
Copy link
Member

We also had this problem in the past. Don't know how we could handle this well.

@sasanjac
Copy link

sasanjac commented Mar 8, 2021

The instance that generates and verifies the lp files should round the values before saving. The tests can then check against these rounded values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants