CryptoNightGPU

[blackmennewstyle]

Hello,

Is CryptoNightGPU algorithm supported? I can see a reference for it inside https://github.com/oliverw/miningcore/blob/master/src/Miningcore/Configuration/ClusterConfig.cs but since there is no coin using that algorithm inside https://github.com/oliverw/miningcore/blob/master/src/Miningcore/coins.json, i imagine the implementation is not complete or no one did not attempt yet?

[blackmennewstyle]

@oliverw Is it possible to bypass the behavior in the CryptoNodeJobManager.cs which always wants to use RandomX when setting a coin with "family": "cryptonote"?

I'm trying to adapt Conceal to miningcore:

 "conceal": {
        "name": "Conceal",
        "canonicalName": "Conceal",
        "symbol": "CCX",
        "family": "cryptonote",
        "website": "https://conceal.network/",
        "market": "",
        "twitter": "https://twitter.com/ConcealNetwork",
        "telegram": "https://t.me/concealnetworkusers",
        "discord": "http://discord.conceal.network/",
        "hash": "cn-gpu",
        "hashVariant": 11,
        "smallestUnit": 1000000,
        "addressPrefix": 31444,
        "addressPrefixTestnet": 31444,
        "explorerBlockLink": "https://explorer.conceal.network/index.html?hash=$hash$#blockchain_block",
        "explorerTxLink": "https://explorer.conceal.network/index.html?hash={0}#blockchain_transaction"
    },

But miningcore returns that error:

[2022-11-18 06:24:44.1857] [I] [ccx1] Starting Pool ... 
[2022-11-18 06:24:44.1857] [E] [ccx1] System.NullReferenceException: Object reference not set to an instance of an object. System.NullReferenceException: Object reference not set to an instance of an object.
   at Miningcore.Blockchain.Cryptonote.CryptonoteJobManager.Configure(PoolConfig pc, ClusterConfig cc) in /home/ceedii/miningcore/src/Miningcore/Blockchain/Cryptonote/CryptonoteJobManager.cs:line 282
   at Miningcore.Blockchain.Cryptonote.CryptonotePool.SetupJobManager(CancellationToken ct) in /home/ceedii/miningcore/src/Miningcore/Blockchain/Cryptonote/CryptonotePool.cs:line 307
   at Miningcore.Mining.PoolBase.RunAsync(CancellationToken ct) in /home/ceedii/miningcore/src/Miningcore/Mining/PoolBase.cs:line 392    at Miningcore.Blockchain.Cryptonote.CryptonoteJobManager.Configure(PoolConfig pc, ClusterConfig cc) in /home/ceedii/miningcore/src/Miningcore/Blockchain/Cryptonote/CryptonoteJobManager.cs:line 282
   at Miningcore.Blockchain.Cryptonote.CryptonotePool.SetupJobManager(CancellationToken ct) in /home/ceedii/miningcore/src/Miningcore/Blockchain/Cryptonote/CryptonotePool.cs:line 307
   at Miningcore.Mining.PoolBase.RunAsync(CancellationToken ct) in /home/ceedii/miningcore/src/Miningcore/Mining/PoolBase.cs:line 392

Which corresponds with that section in CryptoNodeJobManager.cs:

if(pc.EnableInternalStratum == true)
        {
            randomXRealm = !string.IsNullOrEmpty(extraPoolConfig.RandomXRealm) ? extraPoolConfig.RandomXRealm : pc.Id;
            randomXFlagsOverride = MakeRandomXFlags(extraPoolConfig.RandomXFlagsOverride);
            randomXFlagsAdd = MakeRandomXFlags(extraPoolConfig.RandomXFlagsAdd);
        }

[blackmennewstyle]

I managed to successfully implement Conceal in miningcore. It was actually not that hard, the structure of the project allows to do so pretty smoothly, the only limit is coding skills.

Conceal is very similar to Monero but it differs in some aspects. It does not have getinfo RPC method, as they seem to have follow the Bitcoin decision to deprecate that method. However, the method have been deported in a daemon location called getinfo which does not require any parameters but returns similar data like the monero getinfo RPC method minus some information like networkType.

Conceal also has slightly different wallet RPC methods for getbalance, getaddress, transfers and store. Respectively getBalance, getAddresses, sendTransaction and save.

Conceal also calculates its newtwork hashrate based on the formula Difficulty/TARGET_DIFFICULTY. TARGET_DIFFICULTY is constant in the conceal-core which always equals 120.

Conceal has an unique addressPrefix for all its networks (only two actually: testnet and mainnet), which is 0x7ad4 (or 31444 for ccx7).

All the information around these methods and constants are available here:
https://github.com/ConcealNetwork/conceal-core/blob/master/src/CryptoNoteConfig.h
https://github.com/ConcealNetwork/conceal-core/blob/master/src/Rpc/CoreRpcServerCommandsDefinitions.h
https://github.com/ConcealNetwork/conceal-core/blob/master/src/Wallet/WalletRpcServerCommandsDefinitions.h
https://github.com/ConcealNetwork/conceal-core/wiki

At the end, i created my own family of coin called conceal, basically a fork of Cryptonite but only dedicated to conceal, located in https://github.com/oliverw/miningcore/tree/master/src/Miningcore/Blockchain.

I also ended modifying the following files:
https://github.com/oliverw/miningcore/blob/master/src/Miningcore/Configuration/ClusterConfig.cs
https://github.com/oliverw/miningcore/blob/master/src/Miningcore/Configuration/ClusterConfigExtensions.cs

These files allow to create a new coinTemplate (or coin family).

I also modified this file sadly https://github.com/oliverw/miningcore/blob/master/src/Miningcore/Blockchain/Cryptonote/CryptonoteJob.cs because you have a typo in your code when Cryptonight is mispelled Crytonight. If i recall correctly the problem is also present in https://github.com/oliverw/miningcore/blob/master/src/Miningcore/Configuration/ClusterConfig.cs. :'(

I had also to add my newly created coin family in this file https://github.com/oliverw/miningcore/blob/master/src/Miningcore/AutofacModule.cs, in order to be available in the miningcore framework for compilation.

Lastly, i added my newly coin template in the file https://github.com/oliverw/miningcore/blob/master/src/Miningcore/coins.json.

 "conceal": {
        "name": "Conceal",
        "canonicalName": "Conceal",
        "symbol": "CCX",
        "family": "conceal",
        "website": "https://conceal.network/",
        "market": "",
        "twitter": "https://twitter.com/ConcealNetwork",
        "telegram": "https://t.me/concealnetworkusers",
        "discord": "http://discord.conceal.network/",
        "hash": "cn-gpu",
        "hashVariant": 0,
        "difficultyTarget": 120,
        "smallestUnit": 1000000,
        "addressPrefix": 31444,
        "addressPrefixTestnet": 31444,
        "addressPrefixIntegrated": 31444,
        "addressPrefixIntegratedTestnet": 31444,
        "explorerBlockLink": "https://explorer.conceal.network/index.html?hash=$hash$#blockchain_block",
        "explorerTxLink": "https://explorer.conceal.network/index.html?hash={0}#blockchain_transaction"
    },

Few important notes about the conceal node daemon called conceald:
You must use the option --enable-blockchain-indexes otherwise all the RPC methods involving blocktemplate won't work.
You must also use the option start-mining=, otherwise mining won't work.

Example:
conceald --testnet --config-file=/home/ceedii/.conceal/pool.testnet.conf where the file pool.testnet.conf contains:

enable-blockchain-indexes=1
rpc-bind-ip=0.0.0.0
rpc-bind-port=16600
p2p-bind-ip=0.0.0.0
p2p-bind-port=15500
start-mining=ccx7BRXk4eubahkPNe4mmZ1PYwigPmqGT5ciBWib39aQQjWctY6vzA7RuBBkcoSKxEVBQArdvJi5YhEHRY29sSpS9EiD5c2nW5
# (Optional) Only required if you want to run a conceal smartnode
fee-address=ccx7BRXk4eubahkPNe4mmZ1PYwigPmqGT5ciBWib39aQQjWctY6vzA7RuBBkcoSKxEVBQArdvJi5YhEHRY29sSpS9EiD5c2nW5
mining-threads=1
log-level=4
log-file=conceald.testnet.log

Few important notes about the conceal wallet daemon called walletd:
You must use a container-file and container-password, otherwise the daemon won't work.

It's a little bit finicky to work with because it does not trace the RPC method when they are called, only conceald does it.

Example:
walletd --testnet --config=/home/ceedii/.walletd/pool.testnet.conf where the file pool.testnet.conf contains:

bind-address = 127.0.0.1
daemon-address = 127.0.0.1
container-file=conceal.pool.wallet.testnet.container
container-password=**MYSUPERDUPERPASSWORDNOBODYSHOULDKNOWABOUT**
server-root=/home/ceedii/.walletd
log-level=5
log-file=walletd.testnet.log

More information and tutorials for walletd are available here: https://github.com/ConcealNetwork/conceal-core/wiki/Getting-Started

Example of config.json for conceal:

{
    "logging": {
        "level": "debug",
        "enableConsoleLog": true,
        "enableConsoleColors": true,
        "logFile": "miningcore.log",
        "apiLogFile": "api.log",
        "logBaseDirectory": "/home/ceedii/miningcore/build/",
        "perPoolLogFile": false
    },
    "banning": {
        "manager": "Integrated",
        "banOnJunkReceive": true,
        "banOnInvalidShares": false
    },
    "notifications": {
        "enabled": false,
        "email": {
            "host": "localhost",
            "port": 25,
            "user": "",
            "password": "",
            "fromAddress": "noreply@mining-pool.cedric-crispin.local",
            "fromName": "[Mining Pool - Cedric CRISPIN - Developpement]"
        },
        "admin": {
            "enabled": false,
            "emailAddress": "cedric.crispin@gmail.com",
            "notifyBlockFound": true
        }
    },
    "persistence": {
        "postgres": {
            "host": "127.0.0.1",
            "port": 5432,
            "user": "mining_pool_conceal_com",
            "password": "MYSUPERDUPERPASSWORDNOBODYSHOULDKNOWABOUT",
            "database": "mining_pool_conceal_com"
        }
    },
    "paymentProcessing": {
        "enabled": true,
        "interval": 600,
        "shareRecoveryFile": "recovered-shares.txt"
    },
    "api": {
        "enabled": true,
        "listenAddress": "0.0.0.0",
        "port": 4000,
        "metricsIpWhitelist": [],
        "rateLimiting": {
            "disabled": false,
            "rules": [
                {
                    "Endpoint": "*",
                    "Period": "1s",
                    "Limit": 30
                }
            ],
            "ipWhitelist": ["192.168.1.4"]
        }
    },
    "pools": [
        {
            "id": "ccx1",
            "enabled": true,
            "coin": "conceal",
            "NetworkTypeOverride": "testnet",
            "cryptonightMaxThreads": 1,
            "address": "ccx7BRXk4eubahkPNe4mmZ1PYwigPmqGT5ciBWib39aQQjWctY6vzA7RuBBkcoSKxEVBQArdvJi5YhEHRY29sSpS9EiD5c2nW5",
            "rewardRecipients": [
                {
                    "type": "op",
                    "address": "ccx7BRXk4eubahkPNe4mmZ1PYwigPmqGT5ciBWib39aQQjWctY6vzA7RuBBkcoSKxEVBQArdvJi5YhEHRY29sSpS9EiD5c2nW5",
                    "percentage": 0.1
                }
            ],
            "blockRefreshInterval": 250,
            "jobRebroadcastTimeout": 3,
            "clientConnectionTimeout": 600,
            "banning": {
                "enabled": true,
                "time": 600,
                "invalidPercent": 50,
                "checkThreshold": 50
            },
            "ports": {
                "3364": {
                    "listenAddress": "0.0.0.0",
                    "difficulty": 5000,
                    "tls": false,
                    "tlsPfxFile": "/etc/apache2/ssl/www.cedric-crispin.local.pfx",
                    "tlsPfxPassword": "MYSUPERDUPERPASSWORDNOBODYSHOULDKNOWABOUT",
                    "varDiff": {
                        "minDiff": 2500,
                        "maxDiff": null,
                        "targetTime": 15,
                        "retargetTime": 90,
                        "variancePercent": 30,
                        "maxDelta": 500
                    }
                },
                "3365": {
                    "listenAddress": "0.0.0.0",
                    "difficulty": 5000,
                    "tls": true,
                    "tlsPfxFile": "/etc/apache2/ssl/www.cedric-crispin.local.pfx",
                    "tlsPfxPassword": "MYSUPERDUPERPASSWORDNOBODYSHOULDKNOWABOUT",
                    "varDiff": {
                        "minDiff": 2500,
                        "maxDiff": null,
                        "targetTime": 15,
                        "retargetTime": 90,
                        "variancePercent": 30,
                        "maxDelta": 500
                    }
                }
            },
            "daemons": [
                {
                    "host": "127.0.0.1",
                    "port": 16600,
                    "user": null,
                    "password": null
                },
                {
                    "host": "127.0.0.1",
                    "port": 8770,
                    "user": null,
                    "password": null,
                    "category": "wallet"
                }
            ],
            "paymentProcessing": {
                "enabled": true,
                "minimumPayment": 0.1,
                "payoutScheme": "PPLNS",
                "payoutSchemeConfig": {
                    "factor": 0.5
                }
            }
        }
    ]
}

I will submit a PR on the dev branch as soon as possible.

My Conceal mining pool running on miningcore: https://conceal.cedric-crispin.com/