Adds sksl to reduce animations stutter #167
Conversation
android/app/build.gradle
Outdated
| minSdkVersion 16 | ||
| minSdkVersion 17 | ||
| targetSdkVersion 30 | ||
| multiDexEnabled true |
There was a problem hiding this comment.
quill_version now depends on youtube_player_flutter that depends on flutter_inapp_webview that requires min sdk version 17 and multiDexEnabled enabled
| @@ -4,10 +4,10 @@ import 'package:flutter_riverpod/flutter_riverpod.dart'; | |||
| import 'package:layoutr/common_layout.dart'; | |||
There was a problem hiding this comment.
Sorted the imports alphabetically (flutter analyze complains if not)
There was a problem hiding this comment.
Do you know if this is linteable? It seems that it should, if flutter is complaining.
There was a problem hiding this comment.
This is being catch by the linter:
I'm just thinking why Flutter wasn't complaining before about it, but I have no idea why
ggirotto
changed the title
ggirotto
added
enhancement
| @@ -4,10 +4,10 @@ import 'package:flutter_riverpod/flutter_riverpod.dart'; | |||
| import 'package:layoutr/common_layout.dart'; | |||
There was a problem hiding this comment.
Do you know if this is linteable? It seems that it should, if flutter is complaining.
| @@ -21,6 +21,6 @@ | |||
| <key>CFBundleVersion</key> | |||
| <string>1.0</string> | |||
| <key>MinimumOSVersion</key> | |||
| <string>8.0</string> | |||
| <string>9.0</string> | |||
There was a problem hiding this comment.
Why the iOS minimum version was also bumped?
There was a problem hiding this comment.
I don't know why Flutter is automatically bumping this version to 9 every time I build the iOS app:
There's nothing about the minimum version change in the Breaking Changes guide, although they state in Build and release an iOS app
that the minimum supported version is iOS 9.0 (we also have deployment target set to 9.0 in the PBX)
TLDR: I don't know why Flutter automatically bumped, but the version 9 seems to be the correct one
ggirotto
force-pushed
the
shader-junk
branch
2 times, most recently
from
c34ec1c
to
f44d34a
Compare
Ideally we should have integration tests that run the app and re-generate these JSONs every time the code changes, as suggested in Flutter article. Using these pre-compiled JSONs is a short term solution that may be replaced in the future with these integration tests (or even with a Flutter solution) |
This seems relatively easy to do, and I'm not really inclined to add a version that require a manual change every time a new version is required - and we are aware on how to improve it, meaning, already creating a high priority issue to it. I'm open to do this myself if you want to. |
I'm afraid that these integration tests will be very tricky because we'll basically need integration tests for the entire app animations (scroll the main collections list, open a deck details, close deck details, start a deck, answer a question, etc...). Basically we need to cover all actions that we've inside the app today. Although I've never implemented integration tests, it seems at least toilsome to do so, and we have other priorities (server) that have higher priority right now. Do you have something in mind like a MVP for these tests? I think that we can start using a manual approach like the one proposed by this PR and create a project to start implementing these tests and lather remove these animation JSONs |
No description provided.