Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return missing genes for each tool #95

Open
anabbi opened this issue May 6, 2022 · 1 comment
Open

Return missing genes for each tool #95

anabbi opened this issue May 6, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@anabbi
Copy link

anabbi commented May 6, 2022

Hello,

Depending on many factors, number of genes matching between input gene matrix and reference genesets can vary and depending on the tool, it can sometimes add variation in the output. It would be great if deconvolute can return a warning of missing reference genes so the user be cognizant of any downstream discrepancy.

In the long run, it would be great to "harmonize" all tools with stable IDs such as Ensembl IDs.

Thanks for your great package!

@anabbi anabbi added the enhancement New feature or request label May 6, 2022
@grst
Copy link
Collaborator

grst commented May 6, 2022

Hi @anabbi,

that's certainly a good idea!
I think some methods already raise such a warning, but I agree that it would be nice if there was a consistent message for all tools.

Regarding the gene identifier:
All of the tools use HGNC gene symbols in their signatures. I'm not so sure it would be worth re-mapping those to ensemble IDs as they would anyway just be based on the gene symbols.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants