Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problems with openTrunk and setTemps #21

Open
Langer75 opened this issue Sep 27, 2021 · 28 comments
Open

problems with openTrunk and setTemps #21

Langer75 opened this issue Sep 27, 2021 · 28 comments
Labels
bug Something isn't working

Comments

@Langer75
Copy link

Langer75 commented Sep 27, 2021

Hi, I am new with Tesla and I got nearly all function running with my Model 3. Two function will not work as expected:

openTrunk. it is stated that no commandArgs are necessary. How can I distingush between trunk and frunk? I read in the tesla.js github project that it was changed to "rear" and "front" But how can I pass these parameters to openTrunk. Currently it does not work at all.

With set Temp I have the effect that it does not matter whether I pass cammandArgs.driver or commandArgs.pass to setTemps. Both values are changed to the same value. Is this a bug or did I something wrong?

Thanks for your help

Langer

@Langer75
Copy link
Author

Langer75 commented Oct 5, 2021

Ok, I solved the openTrunk problem. But the setTemps problem I can not figure out the problem. Does anybody has the same problem?

@onokje
Copy link
Owner

onokje commented Oct 16, 2021

I will look into it.

@onokje onokje added the bug Something isn't working label Oct 16, 2021
@TomNijsen
Copy link

How did you solve the openTrunk problem? What exact syntax for the commandArgs did you use?

@andijegg
Copy link

I have also the Problem with the open Trunk and Frunk command. Debug give back "invalid_value" what is the right value.

1 or true didn't work

@Langer75
Copy link
Author

Langer75 commented Nov 26, 2021

Hi folks

in tesla.js the line around 90 (openTrunk) has to be adapted. I deleted the line and added the following:
case 'openFrunk': return tjs.openTrunkAsync({authToken, vehicleID}, "front");
case 'openTrunk': return tjs.openTrunkAsync({authToken, vehicleID}, "rear");
After this it should work. No parameters, just use the command "openTrunk" or "openFrunk"

@andijegg
Copy link

Thanks, I'll try this.

@ianwitherow
Copy link
Contributor

@Langer75 Thanks, this worked for me!

@onokje - Would you like a pull request for this (the Frunk and Trunk issue)?

@Langer75
Copy link
Author

A last question on the setTemp driver and passanger issue (see first comment): It seems, that it does not work for a Model3. Can anybody confirm that. For wich model does it work?

@ianwitherow
Copy link
Contributor

@Langer75
I got the different temperatures working for my 2021 Y. The key is that you need to un-sync the temperatures in the car first ("Split" button).
I haven't seen an API call to do this, but I may have just missed it.

@andijegg
Copy link

in tesla.js the line around 90 (openTrunk) has to be adapted. I deleted the line and added the following: case 'openFrunk': return tjs.openTrunkAsync({authToken, vehicleID}, "front"); case 'openTrunk': return tjs.openTrunkAsync({authToken, vehicleID}, "rear"); After this it should work. No parameters, just use the command "openTrunk" or "openFrunk"

Hi, I tried it, but for me it didn't worked... Any Ideas

@Langer75
Copy link
Author

Langer75 commented Dec 30, 2021

In the current Version openTrunk and openFrunc lines are already there. But the parameters have to be adapted (front and rear)

@andijegg
Copy link

andijegg commented Dec 30, 2021

I've adapted the parameters to "front" and "rear", but it does not work at al
Bildschirmfoto 2021-12-30 um 17 37 51

@ianwitherow
Copy link
Contributor

@andijegg
Can you try calling openTrunkAsync from the TeslaJS library directly (outside of node-red)? Make sure to use "front" and "rear" there too despite the documentation. Or try both variations!

Just curious if your issue is with the TeslaJS library instead of this one.

@andijegg
Copy link

andijegg commented Dec 30, 2021

Can you try calling openTrunkAsync from the TeslaJS library directly (outside of node-red)?

I don't know how to do this... sry

@ianwitherow
Copy link
Contributor

@andijegg Gotcha, well just out of curiosity - do other calls from node-red work? Can you open the charge port for instance?
Also, did you restart your node-red instance after updating the tesla.js file?

@andijegg
Copy link

Yes other work. Open/Close Car Open Charge Port etc.

And yes I've restarted the node-red instance after updating the tesla.js file.

@ianwitherow
Copy link
Contributor

@andijegg Anything appear in a debug message payload from the openFrunk node?

Example:
image

@andijegg
Copy link

Yes the same as in the Picture above.

„false“ and „invalide_value“

@ianwitherow
Copy link
Contributor

It must not be picking up the change you made. What's the file path of your tesla.js that you edited?

@andijegg
Copy link

/home/pi/node_modules/node-red-contrib-tesla/tesla.js

@ianwitherow
Copy link
Contributor

Kind of a long shot here, but from your home directory, what do you see when you run:

find . -name 'tesla.js'

Just that one file? Or does it find another?
If you look in the file, does it still have your changes ("front" and "rear")? Or did it revert?

@andijegg
Copy link

It finds two...

./.node-red/node_modules/node-red-contrib-tesla/src/tesla.js
./node_modules/node-red-contrib-tesla/tesla.js
./node_modules/node-red-contrib-tesla/src/tesla.js

@ianwitherow
Copy link
Contributor

Ah, alright - the one you want is that first one: ./.node-red/node_modules/node-red-contrib-tesla/src/tesla.js
Make the edits there, restart node-red, and it should work.

@andijegg
Copy link

both files have the "front" "rear" edit, I've just checked it...

@ianwitherow
Copy link
Contributor

Hm, must be symlinked. Can you reboot the whole machine just to make sure the instance is being restarted? Everything looks fine, not sure what else to suggest here.

@andijegg
Copy link

I‘ll try a restart and report the result

@andijegg
Copy link

There was 3 files... my fault, in the third file, were still the old paterns. I changed it an now it works fine... Thank you for the help!

@ianwitherow
Copy link
Contributor

Hah, I almost asked about that one too.. Glad to hear it's working!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants