Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not except: all and SerializerFieldValueError #7

Open
alexlehn opened this issue Dec 4, 2014 · 2 comments
Open

do not except: all and SerializerFieldValueError #7

alexlehn opened this issue Dec 4, 2014 · 2 comments

Comments

@alexlehn
Copy link
Collaborator

alexlehn commented Dec 4, 2014

There are multiple points in the aserializer.fields.base where is an expect all.
This is vary frustrating because it caches every error and tells you that it is a SerializerFieldValueError.
This has cost us 5h of debugging to find our programming error !!!

is it required to catch all??
except:
raise SerializerFieldValueError(self._error_messages['invalid'], field_names=self.names)

@daccle
Copy link

daccle commented Dec 4, 2014

+1 :)

On Thu, Dec 04, 2014 at 08:13:42AM -0800, alex wrote:

There are multiple points in the aserializer.fields.base where is an expect
all.
This is vary frustrating because it caches every error and tells you that it is
a SerializerFieldValueError.
This has cost us 5h of debugging to find our programming error !!!

is it required to catch all??
except:
raise SerializerFieldValueError(self._error_messages['invalid'], field_names=
self.names)


Reply to this email directly or view it on GitHub.*

@onyg
Copy link
Owner

onyg commented Dec 5, 2014

That's right. THX
by the way. Is a logger mode also helpful for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants