Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PyMPDATA-examples: pylint enabled but still many warnings ignored in the GA workflow #299

Open
slayoo opened this issue Nov 13, 2021 · 16 comments
Open

PyMPDATA-examples: pylint enabled but still many warnings ignored in the GA workflow #299

slayoo opened this issue Nov 13, 2021 · 16 comments

Comments

@slayoo
Copy link
Member

slayoo commented Nov 13, 2021

No description provided.

@slayoo
Copy link
Member Author

slayoo commented Nov 14, 2021 •
edited
Loading

here is what is still to be addressed (i.e., pylint disable flags used), excluding docstring warnings which perhaps we do not really aim at this point for examples code:

.py files:

  • too-many-locals
  • too-many-branches
  • duplicate-code
  • wrong-import-order
  • invalid-name
  • wrong-import-position
  • too-many-arguments
  • trailing-whitespace
  • line-too-long
  • too-few-public-methods
  • too-many-instance-attributes

.ipynb files:

  • duplicate-code
  • wrong-import-position
  • wrong-import-order
  • ungrouped-imports
  • invalid-name
  • trailing-whitespace
  • line-too-long
  • unused-import
  • redefined-outer-name
  • unused-variable
  • too-many-arguments
  • no-member
  • too-many-locals
  • cell-var-from-loop
  • too-few-public-methods

@slayoo
Copy link
Member Author

slayoo commented Nov 18, 2021

let's not try to enforce trailing-whitespace for notebooks!

@slayoo
Copy link
Member Author

slayoo commented Nov 18, 2021

same for wrong-import-position - the pip-install magick will cause it to pop up for every single notebook

@github-actions
Copy link

Stale issue message

@slayoo slayoo changed the title pylint enabled but still many warnings ignored in the GA workflow PyMPDATA-examples: pylint enabled but still many warnings ignored in the GA workflow Jan 18, 2022
@github-actions
Copy link

Stale issue message

@github-actions
Copy link

Stale issue message

@github-actions
Copy link

Stale issue message

@github-actions
Copy link

Stale issue message

@github-actions
Copy link

Stale issue message

@github-actions
Copy link

Stale issue message

@github-actions
Copy link

Stale issue message

@github-actions
Copy link

Stale issue message

@github-actions
Copy link

Stale issue message

@github-actions
Copy link

Stale issue message

@slayoo slayoo reopened this Oct 6, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2023

Stale issue message

@slayoo slayoo reopened this Dec 28, 2023
@github-actions GitHub Actions
Copy link

Stale issue message

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 29, 2024
@slayoo slayoo reopened this Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@slayoo