From 2d2f70d56fdbf71e8f159a645ccd55e0a9055012 Mon Sep 17 00:00:00 2001 From: Mark Phelps <209477+markphelps@users.noreply.github.com> Date: Fri, 18 Oct 2024 12:17:57 -0400 Subject: [PATCH] chore: upgrade flipt-client-browser dep (#1070) Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com> --- libs/providers/flipt-web/package-lock.json | 37 +++++++++---------- libs/providers/flipt-web/package.json | 2 +- .../flipt-web/src/lib/flipt-web-provider.ts | 20 ++-------- package-lock.json | 9 ++--- package.json | 2 +- 5 files changed, 27 insertions(+), 43 deletions(-) diff --git a/libs/providers/flipt-web/package-lock.json b/libs/providers/flipt-web/package-lock.json index 46b7ca8b0..d272cf2b0 100644 --- a/libs/providers/flipt-web/package-lock.json +++ b/libs/providers/flipt-web/package-lock.json @@ -8,7 +8,7 @@ "name": "@openfeature/flipt-web-provider", "version": "0.1.0", "dependencies": { - "@flipt-io/flipt-client-browser": "^0.0.19", + "@flipt-io/flipt-client-browser": "^0.3.1", "tslib": "^2.3.0" }, "devDependencies": { @@ -19,38 +19,37 @@ } }, "node_modules/@flipt-io/flipt-client-browser": { - "version": "0.0.19", - "resolved": "https://registry.npmjs.org/@flipt-io/flipt-client-browser/-/flipt-client-browser-0.0.19.tgz", - "integrity": "sha512-mzWVUPmYU25lrl7E34gn3p7hdFfftQ0Fge4QcgUEyC9UzoMKcXy4FN1hp4yygr3w8Yvyt+9hprJbUJAowT5+mA==", - "license": "MIT" + "version": "0.3.1", + "resolved": "https://registry.npmjs.org/@flipt-io/flipt-client-browser/-/flipt-client-browser-0.3.1.tgz", + "integrity": "sha512-1MFuQuHRENnzVooxrfQjFBLNBfE5uGBJmF2NuPFXTYMZn+sGelFovuNVuKlHqegI3Dqzz9Al2qJlkeFo+MhHxg==" }, "node_modules/@openfeature/core": { - "version": "1.1.0", - "resolved": "https://registry.npmjs.org/@openfeature/core/-/core-1.1.0.tgz", - "integrity": "sha512-aNuvOmqrFxAyzLnEa3YINsUu1pskXyEeMu4O9Kyde0+cS7q+Tgh4KKePwAROXkhhU1RQckW931P41xK5osXAWA==", + "version": "1.4.0", + "resolved": "https://registry.npmjs.org/@openfeature/core/-/core-1.4.0.tgz", + "integrity": "sha512-Cd5eeAouAYaj1RMgVq4gfasoAc4TSkN4fuhloZ3yCQA2t74IdVMAT0iadq1Seqy+G7PZoN2jy706ei9HT55PIg==", "peer": true }, "node_modules/@openfeature/web-sdk": { - "version": "1.0.2", - "resolved": "https://registry.npmjs.org/@openfeature/web-sdk/-/web-sdk-1.0.2.tgz", - "integrity": "sha512-2G3GfJHFGr5kAzs2KEec5wxUFhlNXDKyUTg3IiXTH1nv3d/tyDnyCYKUgSOfEM7ZBSwuEC1/CTBYDCGKVO4uIw==", + "version": "1.2.4", + "resolved": "https://registry.npmjs.org/@openfeature/web-sdk/-/web-sdk-1.2.4.tgz", + "integrity": "sha512-v3RYqMIq+/UXH7eVqfTfp7iWPJ4/Ck5a3RwxAEhypocq5IxUDyEUxXvVU82bkVkbNEKvXYLUWlxT+IuHvh8Eng==", "peer": true, "peerDependencies": { - "@openfeature/core": "1.1.0" + "@openfeature/core": "1.4.0" } }, "node_modules/tslib": { - "version": "2.6.2", - "resolved": "https://registry.npmjs.org/tslib/-/tslib-2.6.2.tgz", - "integrity": "sha512-AEYxH93jGFPn/a2iVAwW87VuUIkR1FVUKB77NwMF7nBTDkDrrT/Hpt/IrCJ0QXhW27jTBDcf5ZY7w6RiqTMw2Q==" + "version": "2.8.0", + "resolved": "https://registry.npmjs.org/tslib/-/tslib-2.8.0.tgz", + "integrity": "sha512-jWVzBLplnCmoaTr13V9dYbiQ99wvZRd0vNWaDRg+aVYRcjDF3nDksxFDE/+fkXnKhpnUUkmx5pK/v8mCtLVqZA==" }, "node_modules/undici": { - "version": "6.13.0", - "resolved": "https://registry.npmjs.org/undici/-/undici-6.13.0.tgz", - "integrity": "sha512-Q2rtqmZWrbP8nePMq7mOJIN98M0fYvSgV89vwl/BQRT4mDOeY2GXZngfGpcBBhtky3woM7G24wZV3Q304Bv6cw==", + "version": "6.20.1", + "resolved": "https://registry.npmjs.org/undici/-/undici-6.20.1.tgz", + "integrity": "sha512-AjQF1QsmqfJys+LXfGTNum+qw4S88CojRInG/6t31W/1fk6G59s92bnAvGz5Cmur+kQv2SURXEvvudLmbrE8QA==", "dev": true, "engines": { - "node": ">=18.0" + "node": ">=18.17" } } } diff --git a/libs/providers/flipt-web/package.json b/libs/providers/flipt-web/package.json index 1a0c978e6..1bde721f3 100644 --- a/libs/providers/flipt-web/package.json +++ b/libs/providers/flipt-web/package.json @@ -2,7 +2,7 @@ "name": "@openfeature/flipt-web-provider", "version": "0.1.0", "dependencies": { - "@flipt-io/flipt-client-browser": "^0.0.19", + "@flipt-io/flipt-client-browser": "^0.3.1", "tslib": "^2.3.0" }, "main": "./src/index.js", diff --git a/libs/providers/flipt-web/src/lib/flipt-web-provider.ts b/libs/providers/flipt-web/src/lib/flipt-web-provider.ts index b86bd87e0..1b9fe8da2 100644 --- a/libs/providers/flipt-web/src/lib/flipt-web-provider.ts +++ b/libs/providers/flipt-web/src/lib/flipt-web-provider.ts @@ -4,9 +4,7 @@ import { JsonValue, ResolutionDetails, Logger, - ProviderStatus, StandardResolutionReasons, - ErrorCode, TypeMismatchError, GeneralError, ProviderFatalError, @@ -80,13 +78,7 @@ export class FliptWebProvider implements Provider { const evalContext: Record = transformContext(context); try { - const resp = this._client?.evaluateBoolean(flagKey, context.targetingKey ?? '', evalContext); - - if (resp?.status === 'failure') { - throw new GeneralError(resp.error_message); - } - - const result = resp?.result; + const result = this._client?.evaluateBoolean(flagKey, context.targetingKey ?? '', evalContext); switch (result?.reason) { case EvaluationReason.DEFAULT: @@ -151,13 +143,7 @@ export class FliptWebProvider implements Provider { const evalContext: Record = transformContext(context); try { - const resp = this._client?.evaluateVariant(flagKey, context.targetingKey ?? '', evalContext); - - if (resp?.status === 'failure') { - throw new GeneralError(resp.error_message); - } - - const result = resp?.result; + const result = this._client?.evaluateVariant(flagKey, context.targetingKey ?? '', evalContext); if (result?.reason === EvaluationReason.FLAG_DISABLED) { return { @@ -175,7 +161,7 @@ export class FliptWebProvider implements Provider { const flagValue: PrimitiveType | U = validateFlagType( flagType, - flagType === 'json' ? result.variant_attachment : result.variant_key, + flagType === 'json' ? result.variantAttachment : result.variantKey, ); return { diff --git a/package-lock.json b/package-lock.json index d2eac5f9f..84707eba5 100644 --- a/package-lock.json +++ b/package-lock.json @@ -13,7 +13,7 @@ "@connectrpc/connect": "^1.4.0", "@connectrpc/connect-web": "^1.4.0", "@flipt-io/flipt": "^1.0.0", - "@flipt-io/flipt-client-browser": "^0.0.19", + "@flipt-io/flipt-client-browser": "^0.3.1", "@growthbook/growthbook": "^1.0.0", "@grpc/grpc-js": "^1.9.13", "@opentelemetry/api": "^1.3.0", @@ -2426,10 +2426,9 @@ "integrity": "sha512-LapnGsMxaf01aJmjeUmfYBwGiFx7+qImv10WfQJjBNGIv9fwmzmA3IzFyod5EtIJ1ck0gEW2C9EK03BQz4/C6Q==" }, "node_modules/@flipt-io/flipt-client-browser": { - "version": "0.0.19", - "resolved": "https://registry.npmjs.org/@flipt-io/flipt-client-browser/-/flipt-client-browser-0.0.19.tgz", - "integrity": "sha512-mzWVUPmYU25lrl7E34gn3p7hdFfftQ0Fge4QcgUEyC9UzoMKcXy4FN1hp4yygr3w8Yvyt+9hprJbUJAowT5+mA==", - "license": "MIT" + "version": "0.3.1", + "resolved": "https://registry.npmjs.org/@flipt-io/flipt-client-browser/-/flipt-client-browser-0.3.1.tgz", + "integrity": "sha512-1MFuQuHRENnzVooxrfQjFBLNBfE5uGBJmF2NuPFXTYMZn+sGelFovuNVuKlHqegI3Dqzz9Al2qJlkeFo+MhHxg==" }, "node_modules/@growthbook/growthbook": { "version": "1.0.0", diff --git a/package.json b/package.json index 5a655ee18..ba90abbc1 100644 --- a/package.json +++ b/package.json @@ -18,7 +18,7 @@ "@connectrpc/connect": "^1.4.0", "@connectrpc/connect-web": "^1.4.0", "@flipt-io/flipt": "^1.0.0", - "@flipt-io/flipt-client-browser": "^0.0.19", + "@flipt-io/flipt-client-browser": "^0.3.1", "@growthbook/growthbook": "^1.0.0", "@grpc/grpc-js": "^1.9.13", "@opentelemetry/api": "^1.3.0",