Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use docker buildx in CI to build containers for other architectures (including ARM) #253

Open
toddbaert opened this issue Nov 22, 2023 · 3 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@toddbaert
Copy link
Member

With the increasing populariry of both OpenFeature and M1 Macs/ARM in general, we should do multi-arch container builds. All containers built as part of this demo should be able to run on x86 and ARM.

This was partially started and then abandoned. See here.

@toddbaert toddbaert added good first issue Good for newcomers help wanted Extra attention is needed labels Nov 22, 2023
@toddbaert toddbaert changed the title Use builx in CI to build containers for other architectures Use docker buildx in CI to build containers for other architectures Nov 22, 2023
@toddbaert toddbaert changed the title Use docker buildx in CI to build containers for other architectures Use docker buildx in CI to build containers for other architectures (including ARM) Nov 22, 2023
@PrateekKumar1709
Copy link

@toddbaert I would like to work on this issue. Can you please assign this to me?

@beeme1mr beeme1mr removed the help wanted Extra attention is needed label Sep 26, 2024
@beeme1mr
Copy link
Member

Sure @PrateekKumar1709, thanks for help!

@PrateekKumar1709
Copy link

Hi @beeme1mr,

Upon reviewing the current CI workflow, I noticed that multi-architecture builds are already enabled using Docker Buildx and QEMU, supporting both amd64 and arm64 platforms as required. This means the containers are already being built for these architectures without any additional changes needed for this aspect.

Optimization: To improve the efficiency of the build process, I suggest introducing Docker build caching. This would reduce the build times by reusing layers from previous builds, especially when there are no significant changes. The caching can be done by adding the cache-from and cache-to parameters in the Docker build steps, like this:

cache-from: type=gha
cache-to: type=gha,mode=max

This addition can help to speed up repeated builds in CI by utilizing GitHub Actions caching.

Please let me know if this seems like a good approach to you and I can raise a PR, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants