Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support mapping of ClientService to an exposed list of attributes #36503

Open
awangc opened this issue Nov 22, 2024 · 1 comment
Open

Support mapping of ClientService to an exposed list of attributes #36503

awangc opened this issue Nov 22, 2024 · 1 comment
Labels
connector/servicegraph enhancement New feature or request needs triage New item requiring triage

Comments

@awangc
Copy link

awangc commented Nov 22, 2024

Component(s)

connector/servicegraph

Is your feature request related to a problem? Please describe.

Currently when enabling virtual nodes in servicegraphs, we can provide a list of attributes that allow a client span to create a virtual server node based on the attribute present. This request is to provide support for similar action for server spans, i.e., a new configuration option that allows us to provide a list of attributes that allow a server span to create a virtual client node based on the attribute present.

This option does not currently exist, so any server span that does not have a corresponding client span gets assigned a generic user node as client, which hides how services are called.

Describe the solution you'd like

With a config like the below:

connectors:
  servicegraph:
     latency_histogram_buckets: [100ms, 250ms, 1s, 5s, 10s]
     dimensions:
       - peer.service
       - client.address
     virtual_node_client_attributes:
       - peer.service
       - client.address

Server spans that have the attribute of peer.service (or client.address) will list the peer.service (or client.address) in the client node in the node graph, instead of the generic user.

Describe alternatives you've considered

No response

Additional context

No response

@awangc awangc added enhancement New feature or request needs triage New item requiring triage labels Nov 22, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
connector/servicegraph enhancement New feature or request needs triage New item requiring triage
Projects
None yet
Development

No branches or pull requests

1 participant