Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Dubbo plugin may have a broken trace problem #12928

Open
steverao opened this issue Dec 19, 2024 · 0 comments · May be fixed by #12930
Open

The Dubbo plugin may have a broken trace problem #12928

steverao opened this issue Dec 19, 2024 · 0 comments · May be fixed by #12930
Assignees
Labels
bug Something isn't working

Comments

@steverao
Copy link
Contributor

Describe the bug

About Dubbo instrumentation, from our customers, we found it will return expected result:


In provider side, it might returns false and causes broken trace with upstream client's trace.
But I can't reproduce it in my local environment, it might causes by several factors.
From our customers' use cases, it will happens in Dubbo 2.7.10. I also talked with maintainer @AlbumenJ from Dubbo community. He expressed we shouldn't use it continuously and he doesn't recommend using it to check the source.
I also noticed there are some related issues in Dubbo community. For detail, please refer to https://github.com/apache/dubbo/issues?q=is%3Aissue+rpccontext+isconsumerside+is%3Aclosed

Steps to reproduce

But I can't reproduce it in my local environment, it might causes by several factors. I found it by our customers.

Expected behavior

The Dubbo instrumentation should produce correct trace.

Actual behavior

In some scenarios, it will produces broken trace due to wrong return of rpcContext.isProviderSide()

Javaagent or library instrumentation version

2.10.0

Environment

JDK: JDK8
OS: CentOS

Additional context

No response

@steverao steverao added bug Something isn't working needs triage New issue that requires triage and removed needs triage New issue that requires triage labels Dec 19, 2024
@steverao steverao self-assigned this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant