Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creation of ClusterRole and Clusterrolebindings cannot be disabled #241

Open
kastl-ars opened this issue Dec 20, 2024 · 0 comments · May be fixed by #242
Open

Creation of ClusterRole and Clusterrolebindings cannot be disabled #241

kastl-ars opened this issue Dec 20, 2024 · 0 comments · May be fixed by #242

Comments

@kastl-ars
Copy link

Dear maintainers,

as far as I can see, the rbac.enabled value does not fully work. The ClusterRole does not have any if-condition pointing to .Values.rbac.enabled:

https://github.com/opencost/opencost-helm-chart/blob/main/charts/opencost/templates/clusterrole.yaml

The ClusterRoleBinding correctly has a if .Values.rbac.enabled condition set:

https://github.com/opencost/opencost-helm-chart/blob/main/charts/opencost/templates/clusterrolebinding.yaml#L1

Kind Regards,
Johannes
kastl-ars added a commit to kastl-ars/opencost-helm-chart that referenced this issue Dec 20, 2024
@kastl-ars
charts/opencost/templates/clusterrole.yaml: add if condition for .Val…
1918c7c 
…ues.rbac.enabled, like on the clusterrolebinding

fix opencost#241
@kastl-ars kastl-ars linked a pull request Dec 20, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

clusterrole.yaml: add if condition for .Values.rbac.enabled kastl-ars/opencost-helm-chart
1 participant
@kastl-ars