From 9fa0d43709d0f76b7bb94548d59870471fb8dde9 Mon Sep 17 00:00:00 2001 From: Humair Khan Date: Wed, 24 Jul 2024 17:00:56 -0400 Subject: [PATCH] increase default expiry for signed url Signed-off-by: Humair Khan --- api/v1alpha1/dspipeline_types.go | 4 ++-- ...tions.opendatahub.io_datasciencepipelinesapplications.yaml | 4 ++-- controllers/config/defaults.go | 2 +- .../case_0/expected/created/apiserver_deployment.yaml | 2 +- .../case_2/expected/created/apiserver_deployment.yaml | 2 +- .../case_3/expected/created/apiserver_deployment.yaml | 2 +- .../case_4/expected/created/apiserver_deployment.yaml | 2 +- .../case_5/expected/created/apiserver_deployment.yaml | 2 +- .../case_7/expected/created/apiserver_deployment.yaml | 2 +- .../case_8/expected/created/apiserver_deployment.yaml | 2 +- .../case_9/expected/created/apiserver_deployment.yaml | 2 +- 11 files changed, 13 insertions(+), 13 deletions(-) diff --git a/api/v1alpha1/dspipeline_types.go b/api/v1alpha1/dspipeline_types.go index 72af4a3f..1dcb30a9 100644 --- a/api/v1alpha1/dspipeline_types.go +++ b/api/v1alpha1/dspipeline_types.go @@ -150,8 +150,8 @@ type APIServer struct { // The expiry time (seconds) for artifact download links when // querying the dsp server via /apis/v2beta1/artifacts/{id}?share_url=true - // Default: 15 - // +kubebuilder:default:=15 + // Default: 60 + // +kubebuilder:default:=60 // +kubebuilder:validation:Optional ArtifactSignedURLExpirySeconds *int `json:"artifactSignedURLExpirySeconds"` } diff --git a/config/crd/bases/datasciencepipelinesapplications.opendatahub.io_datasciencepipelinesapplications.yaml b/config/crd/bases/datasciencepipelinesapplications.opendatahub.io_datasciencepipelinesapplications.yaml index d28b446b..a8af2afb 100644 --- a/config/crd/bases/datasciencepipelinesapplications.opendatahub.io_datasciencepipelinesapplications.yaml +++ b/config/crd/bases/datasciencepipelinesapplications.opendatahub.io_datasciencepipelinesapplications.yaml @@ -68,10 +68,10 @@ spec: type: string type: object artifactSignedURLExpirySeconds: - default: 15 + default: 60 description: 'The expiry time (seconds) for artifact download links when querying the dsp server via /apis/v2beta1/artifacts/{id}?share_url=true - Default: 15' + Default: 60' type: integer autoUpdatePipelineDefaultVersion: default: true diff --git a/controllers/config/defaults.go b/controllers/config/defaults.go index 8dcb620f..412254d9 100644 --- a/controllers/config/defaults.go +++ b/controllers/config/defaults.go @@ -60,7 +60,7 @@ const ( DefaultDBSecretKey = "password" GeneratedDBPasswordLength = 12 - DefaultSignedUrlExpiryTimeSeconds = 15 + DefaultSignedUrlExpiryTimeSeconds = 60 MariaDBName = "mlpipeline" MariaDBHostPrefix = "mariadb" diff --git a/controllers/testdata/declarative/case_0/expected/created/apiserver_deployment.yaml b/controllers/testdata/declarative/case_0/expected/created/apiserver_deployment.yaml index 35eec3d8..8b92f211 100644 --- a/controllers/testdata/declarative/case_0/expected/created/apiserver_deployment.yaml +++ b/controllers/testdata/declarative/case_0/expected/created/apiserver_deployment.yaml @@ -80,7 +80,7 @@ spec: - name: ML_PIPELINE_SERVICE_PORT_GRPC value: "8887" - name: SIGNED_URL_EXPIRY_TIME_SECONDS - value: "15" + value: "60" - name: EXECUTIONTYPE value: PipelineRun - name: CACHE_IMAGE diff --git a/controllers/testdata/declarative/case_2/expected/created/apiserver_deployment.yaml b/controllers/testdata/declarative/case_2/expected/created/apiserver_deployment.yaml index d656ff5b..810ddfc1 100644 --- a/controllers/testdata/declarative/case_2/expected/created/apiserver_deployment.yaml +++ b/controllers/testdata/declarative/case_2/expected/created/apiserver_deployment.yaml @@ -80,7 +80,7 @@ spec: - name: ML_PIPELINE_SERVICE_PORT_GRPC value: "8887" - name: SIGNED_URL_EXPIRY_TIME_SECONDS - value: "15" + value: "60" - name: EXECUTIONTYPE value: PipelineRun - name: CACHE_IMAGE diff --git a/controllers/testdata/declarative/case_3/expected/created/apiserver_deployment.yaml b/controllers/testdata/declarative/case_3/expected/created/apiserver_deployment.yaml index 3f7ccd43..c7981966 100644 --- a/controllers/testdata/declarative/case_3/expected/created/apiserver_deployment.yaml +++ b/controllers/testdata/declarative/case_3/expected/created/apiserver_deployment.yaml @@ -80,7 +80,7 @@ spec: - name: ML_PIPELINE_SERVICE_PORT_GRPC value: "8887" - name: SIGNED_URL_EXPIRY_TIME_SECONDS - value: "15" + value: "60" - name: EXECUTIONTYPE value: PipelineRun - name: CACHE_IMAGE diff --git a/controllers/testdata/declarative/case_4/expected/created/apiserver_deployment.yaml b/controllers/testdata/declarative/case_4/expected/created/apiserver_deployment.yaml index 6d163e59..16131faa 100644 --- a/controllers/testdata/declarative/case_4/expected/created/apiserver_deployment.yaml +++ b/controllers/testdata/declarative/case_4/expected/created/apiserver_deployment.yaml @@ -80,7 +80,7 @@ spec: - name: ML_PIPELINE_SERVICE_PORT_GRPC value: "8887" - name: SIGNED_URL_EXPIRY_TIME_SECONDS - value: "15" + value: "60" - name: EXECUTIONTYPE value: PipelineRun - name: CACHE_IMAGE diff --git a/controllers/testdata/declarative/case_5/expected/created/apiserver_deployment.yaml b/controllers/testdata/declarative/case_5/expected/created/apiserver_deployment.yaml index c5be15a7..8f193788 100644 --- a/controllers/testdata/declarative/case_5/expected/created/apiserver_deployment.yaml +++ b/controllers/testdata/declarative/case_5/expected/created/apiserver_deployment.yaml @@ -84,7 +84,7 @@ spec: - name: ML_PIPELINE_SERVICE_PORT_GRPC value: "8887" - name: SIGNED_URL_EXPIRY_TIME_SECONDS - value: "15" + value: "60" - name: EXECUTIONTYPE value: PipelineRun - name: CACHE_IMAGE diff --git a/controllers/testdata/declarative/case_7/expected/created/apiserver_deployment.yaml b/controllers/testdata/declarative/case_7/expected/created/apiserver_deployment.yaml index c2e090ec..b9603e2d 100644 --- a/controllers/testdata/declarative/case_7/expected/created/apiserver_deployment.yaml +++ b/controllers/testdata/declarative/case_7/expected/created/apiserver_deployment.yaml @@ -84,7 +84,7 @@ spec: - name: ML_PIPELINE_SERVICE_PORT_GRPC value: "8887" - name: SIGNED_URL_EXPIRY_TIME_SECONDS - value: "15" + value: "60" - name: EXECUTIONTYPE value: Workflow - name: DB_DRIVER_NAME diff --git a/controllers/testdata/declarative/case_8/expected/created/apiserver_deployment.yaml b/controllers/testdata/declarative/case_8/expected/created/apiserver_deployment.yaml index 36352524..ae01ded7 100644 --- a/controllers/testdata/declarative/case_8/expected/created/apiserver_deployment.yaml +++ b/controllers/testdata/declarative/case_8/expected/created/apiserver_deployment.yaml @@ -92,7 +92,7 @@ spec: - name: ML_PIPELINE_SERVICE_PORT_GRPC value: "8887" - name: SIGNED_URL_EXPIRY_TIME_SECONDS - value: "15" + value: "60" - name: ML_PIPELINE_TLS_ENABLED value: "true" - name: EXECUTIONTYPE diff --git a/controllers/testdata/declarative/case_9/expected/created/apiserver_deployment.yaml b/controllers/testdata/declarative/case_9/expected/created/apiserver_deployment.yaml index 788b2faa..be53d39b 100644 --- a/controllers/testdata/declarative/case_9/expected/created/apiserver_deployment.yaml +++ b/controllers/testdata/declarative/case_9/expected/created/apiserver_deployment.yaml @@ -84,7 +84,7 @@ spec: - name: ML_PIPELINE_SERVICE_PORT_GRPC value: "8887" - name: SIGNED_URL_EXPIRY_TIME_SECONDS - value: "15" + value: "60" - name: EXECUTIONTYPE value: Workflow - name: DB_DRIVER_NAME