Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P1] Look into potential conflict with Service Mesh integration #7

Closed
heyselbi opened this issue Jun 19, 2023 · 6 comments
Closed

[P1] Look into potential conflict with Service Mesh integration #7

heyselbi opened this issue Jun 19, 2023 · 6 comments
Assignees
Labels
kind/enhancement Enhancement to current features odh-release/1.8 Need to do for ODH Release v1.8.0

Comments

@heyselbi
Copy link

heyselbi commented Jun 19, 2023

The Service Mesh integration with RHODS is in progress. This is a blocker until we have the service mesh integration with RHODS is fully completed.


As of July 14th, KServe on-boarding into ODH is, in practice, complete for the core components; i.e. the controller, agent, router and storage-initializer.

For ODH, Istio/Maistra Service Mesh was chosen as the networking layer. This means that Service Mesh is a pre-requisite for ODH-KServe.

In parallel, a tighter Service Mesh integration is being worked on. At the moment, that work is being done in feature branches and forks, until it is stable enough; e.g of some locations of the code:

At the time of writing, the most prominent point of conflict is authentication/authorization configurations. See related manifests here: (link). OAuth proxy is being replaced in favor of MeshSidecars+Authorino. The current setup is tailored to work well with notebooks and the odh-dashboard, but other components are not working good. For ModelMesh, there is a workaround (here and here).

The authorization/authentication configs are set on the Istio ingress-gateway. KServe also uses this gateway and doesn't expect such configs which effectively block infer requests.

@heyselbi
Copy link
Author

@israel-hdez is this still an issue? If not, could you provide 1-2 sentence summary and close it out.

@israel-hdez
Copy link

It is still an issue. Although we can apply both KServe + ServiceMesh intergration work, configurations are not good and, AFAIK, infer requests become blocked.

@taneem-ibrahim
Copy link

@israel-hdez Please add the description for the issue

@taneem-ibrahim taneem-ibrahim added the kind/enhancement Enhancement to current features label Jul 13, 2023
@israel-hdez
Copy link

@israel-hdez Please add the description for the issue

@taneem-ibrahim
I've updated the main comment with the details I know.

@heyselbi heyselbi added the odh-release/1.8 Need to do for ODH Release v1.8.0 label Jul 19, 2023
israel-hdez pushed a commit to israel-hdez/kserve that referenced this issue Aug 15, 2023
@israel-hdez
Copy link

Update:

The work done here is potentially a point of conflict: opendatahub-io/odh-model-controller#65.

I've already mentioned it to the people working on the Service Mesh integration to make them aware.

@israel-hdez
Copy link

This is a long-running task.

The SM integration work is being tracked in this ticket: opendatahub-io/opendatahub-community#97.

Since KServe was already adopted in ODH, perhaps it is better to address any conflict under the scope of the service mesh integration, which is being worked in feature branches. It looks like we simply need to provide guidance to enable the Service Mesh team for a smooth integration. Such conversation can happen in other channels.

So, I'm closing this ticket, because it is not actionable at the moment. We can later create new tickets with the specific actionable work, if any.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhancement to current features odh-release/1.8 Need to do for ODH Release v1.8.0
Projects
Status: No status
Status: No status
Status: Done
Development

No branches or pull requests

3 participants