Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate code #1094

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Remove duplicate code #1094

wants to merge 1 commit into from

Conversation

gnn
Copy link
Collaborator

@gnn gnn commented Feb 6, 2023 •
edited
Loading

Remove lines already present as lines 566-574 and 338-346, respectively.

Fixes #1093.

Before merging into dev-branch, please make sure that

  • the CHANGELOG.rst was updated.
  • new and adjusted code is formated using black and isort.
  • the Dataset-version is updated when existing datasets are adjusted.
  • the branch was merged into the
    continuous-integration/run-everything-over-the-weekend-2022-11-10-branch.
  • the workflow is running successful in Test mode.
  • the workflow is running successful in Everything mode.

@gnn
Remove duplicate code
80502ad 
Remove lines already present as lines 566-574 and 338-346, respectively.
@gnn gnn self-assigned this Feb 7, 2023
@gnn gnn requested a review from khelfen February 7, 2023 01:34
@gnn
Copy link
Collaborator Author

gnn commented Feb 7, 2023

Sorry. Got a bit sidetracked because I spotted some weird stuff in "CHANGELOG.rst" while merging this into the CI. Merged it there now though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khelfen khelfen khelfen approved these changes

Assignees

@gnn gnn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

There's duplicated code in "pipeline.py".
2 participants
@gnn @khelfen