[Missing translation] "none" is not translatable - Follow up from #13018

[filipefurtad0]

Description

A missing translation was introduced on issue #13018: when no Tax Category is attributed to a product, the string none is displayed -> it cannot be translated into other locales.

Expected Behavior

The string none on the All Products report is translatable.

Actual Behaviour

The string none on the All Products report is not translatable.

Steps to Reproduce

0. As a hub admin, make sure you have a product without an attributed tax category
1. Visit the All Products report
2. Render the report and notice that none string is not translatable

Animated Gif/Screenshot

Workaround

Live with the English version of the string.

Severity

bug-s3: a feature is broken but there is a workaround

Your Environment

• Version used: v5.0.8
• Browser name and version: All
• Operating System and version (desktop or mobile): All

Possible Fix

[chahmedejaz]

Hi @filipefurtad0, Thanks for raising this one. Yes, it would be great to have the translation for "none."
It's the case with every column with an empty value in all the reports. If the column doesn't have any value (nil) it renders a hard-coded English text "none".
Just to confirm, we will be addressing this issue for every report.

[chahmedejaz]

Note for dev:
I think we would be replacing the hard-coded "none" with the translation in the below lines. Thanks

openfoodnetwork/lib/reporting/report_row_builder.rb

Lines 81 to 83 in ee2a6bf

	def format_cell(value, column = nil)
	return "none" if value.nil?