-
-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow producer to edit their products on hubs' orders #13031
Comments
As this one is touchy, @filipefurtad0 or @drummer83 can you review issue's description before @chahmedejaz starts? (hence the block label) ping @tschumilas if you have time as well. |
Sure, my thoughts below. For clarification:
Can the supplier see products of other suppliers on the 'order details' page? |
@drummer83 thanks ❤️
Yes.
No. That's what I've meant by "Other products are hidden" but i see now this is not clear enough. I'm changing this |
Hey @RachL , Thank you for pinging, apologies I only got to this now. Great description, indeed this one is a bit tricky. Some open questions to me:
Should the Producer be able to see the order total? I'm wondering if it is not sensitive or private information in this context. Even if not, it might just be confusing, that the total not reflect the sum of the displayed line items. What do you think?
I think there might be an exception to consider, which is the case in which an order only has line items from a given Producer. In that case, with the possibility to edit its own line items, it should be possible to remove them all, which currently triggers a pop-up message asking about order cancellation. Should the Producer be allowed to cancel the order, via confirmation of removing the last line item of an order? |
thanks @filipefurtad0 !
Indeed, you are right so perhaps let's just hide all the bottom section, even adjustments. I've also seen that I've forgotten the ship button. So the whole page would look like this:
Good point! Thanks for raising this, I always forget this one 🤦♀️ I would say yes: it's a hub order, but if it concerns only the producer then it remains logic. @tschumilas do you confirm this aligns with your community? |
I agree - if it happens that a producer's product is the last or only one on a hub's order, then the producer should see and accept the confirmation to cancel the order. It will take some education for producers because this confirmation will likely make them nervous - but I don't think it will happen very often. I think ususally producers will be adding items to orders. |
Great thanks for confirming @tschumilas @chahmedejaz I've updated the issue description and removed the block label: all yours 💪 |
Description
- As a: producer supplying one or several hubs and who have the ability to edit their lineitems
- On page:
/admin/orders
and BOM/admin/orders/bulk_management
- I want to be able to do: see the hub orders containing my products in
admin/orders
and BOM/admin/orders/bulk_management
and be able to edit them :On BOM page, only items from the producer are displayed, so if the user has only access to one producer, the list is filtered on that user (same for hub and order cycle):
Only producers where the hub has given the ability to edit can do that. This ability would be given here in a new setting
/admin/enterprises/ENTERPRISENAME/edit#/shop_preferences_panel
What's this?
should display : Enable your suppliers to see orders containing their products, and edit quantity and weight for their own products onlyCustomer emails would remain hidden as currently. and if the setting "customer names in reports" is not set, we need to hide them
On an order, only the order detail tab should be made available to the producer.
Acceptance Criteria and Test
First thing: granting access
/admin/enterprises/ENTERPRISENAME/edit#/shop_preferences_panel
. See content in issue descriptionScenario 1 : access is granted
/admin/orders
and BOM. Other orders from the hub should not be available.Scenario 2 : access is not granted
Previous discussions
openfoodfoundation/wishlist#172
#12893
The text was updated successfully, but these errors were encountered: