Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightly builds aren't running nightly #8202

Open
ofTheo opened this issue Nov 19, 2024 · 3 comments
Open

Nightly builds aren't running nightly #8202

ofTheo opened this issue Nov 19, 2024 · 3 comments

Comments

@ofTheo
Copy link
Member

ofTheo commented Nov 19, 2024

@danoli3 did you change the behavior to only build when there have been changes to the repo?

When I look at the nightly actions they just say "Skipped"

image
@dimitre
Copy link
Member

dimitre commented Nov 19, 2024

there was a change by @danoli3 where this was removed from nightly and manual. should we put back?

on: 
  workflow_dispatch:
    inputs:
          release:
            description: 'release'     
            required: true
            default: 'nightly'

@dimitre
Copy link
Member

dimitre commented Nov 19, 2024

I've put back manual nightly from before changes to see if it run. It is now called manual-nightly-ok
and it fails in line 430 of scripts/dev/create_package.sh which seems to be an incomplete command:

-t $RELEASE

I disagree of the latest changes in manual-nightly. it should be simple and do only what it means, a nightly created manually, not by tag, not including the final release.

@ofTheo
Copy link
Member Author

ofTheo commented Nov 19, 2024

Thanks @dimitre - maybe we can revert that one back?

This seems like a stable place to try from:https://github.com/openframeworks/openFrameworks/blob/47583f6165a9384cdf37ea009c20bf5abc4d9954/.github/workflows/manual-nightly.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants