Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to set elements public or private #88

Closed
8 tasks done
ehmatthes opened this issue Jul 24, 2015 · 3 comments
Closed
8 tasks done

Allow users to set elements public or private #88

ehmatthes opened this issue Jul 24, 2015 · 3 comments

Comments

@ehmatthes
Copy link
Member

  • All elements, including the organization, are considered private first.
  • Toggling privacy
    • Setting an element private cascades down the hierarchy.
    • Setting an element public cascades up the hierarchy.
    • Implement on edit_sa_summary page? (check for cascading issues after processing form?)
    • Write a separate test for this, because it's so critical.
  • Filter for privacy
    • In read-focused views
  • Avoid confusion about 'public' referring to the political notion of a public school.
@ehmatthes ehmatthes added this to the Revise for sharing milestone Jul 24, 2015
@ehmatthes
Copy link
Member Author

  • Added public attribute to Organization.
  • On organizations page, list:
    • orgs that user owns
    • orgs users has edit permissions on
    • public orgs
    • test these

@ehmatthes
Copy link
Member Author

  • Implement an organization_admin page.
    • Based on OrganizationAdminForm(OrganizationForm)
    • Allows editing of aliases
    • Lists editors
      • Not modifying the editors quite yet, just listing them.
    • Allows toggling of public attribute
      • Setting private sets all elements in organization private
    • Tests for all of this.
      • Critical tests written
        • Test that toggling org private works.
        • Test that toggling org private cascades down to all elements.
      • If test not written now, make a comment noting the specific test that needs to be written.
    • Break this into two pages:
      • organization_admin_edit; as currently coded, allows modifying the org.
      • organization_admin_summary; just displays admin-related informatoin for org.

@ehmatthes
Copy link
Member Author

  • Implement toggling of privacy on individual elements, on edit_summary page.
    • for sa
      • add checkbox on form for all elements; that way I can easily see if cascade is working properly.
      • Write a test for ability to change sa to private, and that privacy cascades down.
    • for sdas
    • for cas
    • for eus
    • explain default cascading behavior
      • privacy cascades down
      • public cascades up
    • cascade public down option
    • write basic security tests for all of these
      • test that privacy works, and cascades down.
      • test that changing public does not affect visibility of a private org.
    • list non-security tests to write
      • tests about changing from private to public.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant