Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interface-name blocks the use of "identifer: mac-address" #6631

Open
oybed opened this issue Jul 29, 2024 · 5 comments
Open

interface-name blocks the use of "identifer: mac-address" #6631

oybed opened this issue Jul 29, 2024 · 5 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@oybed
Copy link
Member

oybed commented Jul 29, 2024

When providing an interface with the identifier: mac-address set (per nmstate docs [1]) the assisted service fails to create the image due to missing interface-name. This is new with the change from #6305 and now seeing this problem with OpenShift v4.16.

Example NMState

    - name: ens2f0
      mac-address: 01:23:45:67:89:ab
      type: ethernet
      state: up
      identifier: mac-address

Example error:
image

[1]: https://nmstate.io/features/mac_identifier.html

@oybed oybed changed the title interface-name blocks the use of identifer=mac-address interface-name blocks the use of "identifer: mac-address" Jul 29, 2024
@rccrdpccl
Copy link
Contributor

cc @AlonaKaplan

@AlonaKaplan
Copy link
Contributor

AlonaKaplan commented Aug 1, 2024

@oybed MAC identifier nmstate feature is not supported by assisted installer.
AI resides on the mapping passed by the user between the interface name in the nmstate yaml to the MAC address.
We are planning to allow passing nmstate yaml with nmpolicy/mac-identifier which will eliminate the need for the iface-name to MAC mapping. This new feature is currently in initial development stages.

EDIT: If you will remove the identifier: mac-address from your nmstate yaml it should work. It doesn't matter what name you put in the name section. assited-installer will take care of substituting it with the correct name based on the MAC mapping.

@oybed
Copy link
Member Author

oybed commented Aug 1, 2024

@AlonaKaplan thanks for the response. Yes, we removed the identifier: mac-address to make it work, but it seems strange to not support an advertised feature of nmstate (see earlier nmstate link).

Either way, the error message displayed to the user is not very friendly to understand that the identifier: mac-address is the culprit, so at least update the frontend to display a more descriptive message.

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 31, 2024
@AlonaKaplan
Copy link
Contributor

The issue with identifier: mac-address was fixed in PR #6715 and should work now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

4 participants