Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement namespace selector for pod webhook #93

Open
tardieu opened this issue Sep 13, 2024 · 2 comments
Open

Implement namespace selector for pod webhook #93

tardieu opened this issue Sep 13, 2024 · 2 comments
Assignees
Milestone

Comments

@tardieu
Copy link
Contributor

tardieu commented Sep 13, 2024

Pod webhooks have the potential to block pod admission, causing hard deadlocks if faulty or misconfigured. Other projects leveraging pod webhooks such as Kueue support scoping their pod webhooks to specific namespaces. See for example https://kueue.sigs.k8s.io/docs/tasks/run/plain_pods/.

  podOptions:
    # You can change namespaceSelector to define in which 
    # namespaces kueue will manage the pods.
    namespaceSelector:
      matchExpressions:
      - key: kubernetes.io/metadata.name
        operator: NotIn
        values: [ kube-system, kueue-system ]

We should consider implementing such a namespace selector capability in InstaSlice.

@harche
Copy link
Contributor

harche commented Sep 13, 2024

/cc @sairameshv

@asm582 asm582 added this to the v0.1 milestone Sep 13, 2024
@sairameshv
Copy link
Member

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants