Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too many warnings hinders save #10516

Open
jidanni opened this issue Oct 26, 2024 · 7 comments · May be fixed by #10595
Open

Too many warnings hinders save #10516

jidanni opened this issue Oct 26, 2024 · 7 comments · May be fixed by #10595
Labels
good first issue Best for first-time contributors. No experience necessary! usability An issue with ease-of-use or design

Comments

@jidanni
Copy link
Contributor

jidanni commented Oct 26, 2024

Description

OK, we made an edit, pressed Save, entered our changeset comment, and...
Let's say there are 1000 warnings. I.e., the scrollbar indicator "A" is even smaller.
And say those warnings are all for bus routes and we have never rode a bus in our lives and they certainly are not our fault.

So we want to hurry up and find the final Upload button, but we must scroll past all those warnings first.

Yes we could grab the scrollbar and force it down.

But we don't edit often and are not sure that there is even a final Upload button at the end of all those warnings.

We try the X (B) but that just cancels our edit!

One solution would be a floating final Upload button, always visible.

Screenshots

Screenshot 2024-10-26 17 31 38

@StC-OSM
Copy link

StC-OSM commented Nov 7, 2024

I was going to create a ticket to complain about missing warnings when I found this one 😄

I believe that the real issue here is the design choice to display all warnings, including those that were there previously. Ideally there would be an option to see them, but the default behavior would be to display only warnings triggered by the changeset that is being uploaded

@andrewharvey
Copy link
Contributor

Ideally there would be an option to see them, but the default behavior would be to display only warnings triggered by the changeset that is being uploaded

Agreed, I've seen users completely new to OSM, feel overwhelmed and confused by these warnings unrelated to their changes.

@tyrasd
Copy link
Member

tyrasd commented Dec 10, 2024

Usually, iD only shows errors for features one has actually modified in the changeset (incl. newly created features). But especially for route relations, it can easily happen that a small change in a single road indirectly touches potentially lots of relations.

I agree that the UI is in such situations totally overloaded with warnings and not useful for the mappers. A simple solution would be to limit the number of displayed warnings and have an ellipsis at the end to indicate that there are actually more warnings.

@tyrasd tyrasd added usability An issue with ease-of-use or design good first issue Best for first-time contributors. No experience necessary! labels Dec 10, 2024
@StC-OSM
Copy link

StC-OSM commented Dec 10, 2024

As discussed in another issue report, an admittedly less simple solution would be to only display the warnings that were not present before the changeset (i.e. not burden the contributor with the errors of their predecessors). Less simple, but more accurate. Especially in terms of route breaking.

@Ravish990
Copy link

Hi, My name is Ravish . I study at Polaris School Of Technology ,where I am in first Year. I am interest in contributing the organization and solving this issue. Will you please assign me the issue?? I love to fix it properly.

@tyrasd
Copy link
Member

tyrasd commented Dec 13, 2024

this issue is already being worked on by @AkashNegi1 in #10595

@Ravish990
Copy link

Ravish990 commented Dec 13, 2024

Ok I am unaware about it.
Any help feel free to reach out I am always excited for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Best for first-time contributors. No experience necessary! usability An issue with ease-of-use or design
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants