-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
semi-automated PD on raspbian scripts #2347
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2347 +/- ##
===========================================
- Coverage 55.77% 45.66% -10.12%
===========================================
Files 87 100 +13
Lines 6890 11890 +5000
Branches 0 870 +870
===========================================
+ Hits 3843 5429 +1586
- Misses 3047 6170 +3123
- Partials 0 291 +291 ☔ View full report in Codecov by Sentry. |
@jwhui @sherysheng Can we prioritize getting this change in soon? It appears we're waiting on this for some PD client qualifying tests in certification. |
The task is taken over by @yangsong-cnyn. He'll either update this PR soon or continue the work in a new PR like #2510. |
…nd permanently removes the hook files
db5599a
to
94e7b6e
Compare
33f7bef
to
6d74f5b
Compare
WAN_INTERFACE="eth0" | ||
WPAN_INTERFACE="wpan0" | ||
|
||
RADVD_CONF="/etc/radvd.conf" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can remember, 2 issues we noticed today regarding radvd:
- Radvd is not installed.
- Radvd may not have a config file at this point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need handle permission to write files on the system, maybe change to root
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
failure of radvd is also from mismatched OS release signature
interface eth0 | ||
ipv6rs | ||
iaid 1 | ||
ia_pd 2/::/64 - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When trying out this PR, we noticed that there were two lines noipv6
and noipv6rs
at the end of this file. Not sure how they were added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably here:
ot-br-posix/script/_border_routing
Line 84 in ff7227e
noipv6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the outside noipv6 and noipv6rs was from the default config, inside the request RA config (which under interface eth0) we were requesting /64 prefix, so it should be fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know. Given the default config has both noipv6
and noipv6rs
, doesn't it need both ipv6
and ipv6rs
for the interface?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the outside noipv6 and noipv6rs won't affect the block of "request RA" config
[Service] | ||
ProtectSystem=false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This didn't work. It needs further investigation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can change the whole service file, refer to the design doc go/ot-ref-pd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The root cause is that full raspi OS release for Raspi 5 is signatured "debian" instead of "raspian"
No description provided.