Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdkWrapper dont fire event when publisher don't have a DOM element #56

Open
2 tasks done
kascote opened this issue Oct 26, 2017 · 5 comments
Open
2 tasks done

sdkWrapper dont fire event when publisher don't have a DOM element #56

kascote opened this issue Oct 26, 2017 · 5 comments
Assignees

Comments

@kascote
Copy link
Contributor

kascote commented Oct 26, 2017

New issue checklist

General information

  • Library version(s): 2.0.12
  • iOS/Android/Browser version(s): Chrome 62, Firefox 57b
  • Devices/Simulators/Machine affected: Linux
  • Reproducible in the demo project? (Yes/No): No found a sample using this way
  • Related issues:

Bug report

When generate a publisher without a DOM element, never receive the videoElementCreated event

Expected behavior

Receive the DOM element on the event

Actual behavior

The event never fire

Steps to reproduce

Crash log? Screenshots? Videos? Sample project?

import { OpenTokSDK } from 'opentok-accelerator-core'

const cfg = {
  api_key: "XXX",
  session: "XXXXX",
  token: "XXXXX"
}

const properties = { insertDefaultUI: false }
const events = {
  'videoElementCreated': (event) => { console.warn('videoElementCreated', event)}
}

const sdk = new OpenTokSDK({
  apiKey: cfg.api_key,
  sessionId: cfg.session,
  token: cfg.token
})
const startCall = () => { sdk.publish(null, properties, events, true)  }
sdk.connect().then(() => { startCall() } )

Question or Feature Request

If use plain OT library work as advertised

const session = OT.initSession(cfg.api_key, cfg.session)
const properties = { insertDefaultUI: false }
session.connect(cfg.token, (error) => {
  if (error) {
    console.error('connection error', error)
  } else {
    let publisher = OT.initPublisher(null, properties);
    publisher.on('videoElementCreated', (event) => console.warn('videoElementCreated', event) )
    session.publish(publisher);
  }
})
@maikthomas
Copy link
Contributor

@kascote we're looking into this and have verified the error, haven't fixed it yet. If you happen have a fix feel free to submit PR or paste code here.

@kascote
Copy link
Contributor Author

kascote commented Nov 2, 2017

@maikthomas I don't debugged it yet, I will jump into it in the next days, will keep you posted if found something.

ps: By the moment I'm using publisher.videoElement() to get the video dom element.

@maikthomas maikthomas self-assigned this Nov 16, 2017
@opentok opentok deleted a comment from Jagdeep-Sing Jan 16, 2018
@marvader
Copy link

Any news its been 3 years now?

@maikthomas
Copy link
Contributor

Afraid I can't help with this anymore.
Maybe @msach22 can help you out :)

@michaeljolley
Copy link
Contributor

@kascote thanks for reporting this. I'm sorry it's taken so long. We are now allocating resources to support all the accelerators in a much more aggressive way. I'm looking into this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants