Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotate 5xx client calls with an error tag #111

Open
pavolloffay opened this issue Oct 23, 2018 · 2 comments
Open

Annotate 5xx client calls with an error tag #111

pavolloffay opened this issue Oct 23, 2018 · 2 comments

Comments

@pavolloffay
Copy link
Collaborator

We could add error tag to client spans for returned 5xx codes.

Related issue for async server API #91
@pavolloffay pavolloffay mentioned this issue Oct 23, 2018
Open
@pavolloffay
Copy link
Collaborator Author

The MP-OT spec defines that error tag SHOULD be added only for 4xx (client codes). If the server side is not traced and 5xx is returned I would also consider that operation as failed or errored.

@pavolloffay
Copy link
Collaborator Author

Reported in MP-OT microprofile/microprofile-opentracing#114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pavolloffay