Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing character 萜 #496

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Add missing character 萜 #496

merged 1 commit into from
Jun 24, 2024

Conversation

@xatier
Copy link
Contributor Author

xatier commented Jun 14, 2024

Terpenes and terpenoids 💨

@ChiahongHong
Copy link
Contributor

Great! Although it won't affect the actual outcome, should we change the encoding of this character from big5 to utf8 to maintain encoding correctness before removing the encoding field as discussed in #491 (comment)?

@xatier
Copy link
Contributor Author

xatier commented Jun 15, 2024

Sure thing, fixed! Thanks for the advice!

@tianjianjiang
Copy link
Member

雖然可能不常這樣寫,但我有點好奇「萜烯烴」會不會正確地轉換出來,還是會變成「萜烯聽」或其他的組合。

@ChiahongHong
Copy link
Contributor

@tianjianjiang

I think this special case is inherently difficult to predict the outcome, so it should be fine.

If necessary, we can also add 萜烯烴 to the list.

video.mp4

@tianjianjiang
Copy link
Member

@tianjianjiang

I think this special case is inherently difficult to predict the outcome, so it should be fine.

If necessary, we can also add 萜烯烴 to the list.

@ChiahongHong
Thank you for the usage video, that's really helpful.

I also anticipate that difficult situation. As long as it is still acceptible to you (and hopefully the online learning algorithm will kick in soon enough), I have no strong preference for adding 萜烯烴 or not.

Copy link
Contributor

@lukhnos lukhnos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lukhnos lukhnos merged commit 61796c2 into openvanilla:master Jun 24, 2024
1 check passed
@xatier xatier deleted the tie branch July 7, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants