Verify minicpm 2b dpo #738
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wovchena
requested changes
Aug 5, 2024
| @@ -349,6 +349,55 @@ jobs: | |||
| && timeout 50s ./build/samples/cpp/beam_search_causal_lm/beam_search_causal_lm ./notus-7b-v1/ 69 | |||
| | diff <(timeout 50s ./samples/python/beam_search_causal_lm/beam_search_causal_lm.py ./notus-7b-v1/ 69) - | |||
|
|
|||
| cpp-beam_search_causal_lm-MiniCPM-2B-dpo: | |||
| runs-on: ubuntu-20.04-16-cores | |||
There was a problem hiding this comment.
Suggested change
| runs-on: ubuntu-20.04-16-cores | |
| runs-on: ubuntu-20.04 |
Try a smaller runner. If it fails, switch to ubuntu-20.04-4-cores
| source ./ov/setupvars.sh | ||
| python -m pip install --upgrade-strategy eager -r ./samples/requirements.txt --pre --extra-index-url https://storage.openvinotoolkit.org/simple/wheels/nightly | ||
| python -m pip install ./thirdparty/openvino_tokenizers/[transformers] --pre --extra-index-url https://storage.openvinotoolkit.org/simple/wheels/nightly | ||
| optimum-cli export openvino --trust-remote-code --weight-format fp16 --model openbmb/MiniCPM-2B-dpo-fp16 MiniCPM-2B-dpo-fp16 |
There was a problem hiding this comment.
The model doesn't have a license. https://huggingface.co/openbmb/MiniCPM-2B-dpo-fp16/tree/main. We can't test it until it gets a compatible license. Please, submit an issue to https://huggingface.co/openbmb/MiniCPM-2B-dpo-fp16/ asking to add the license. I didn't think about it earlier. Sorry. I updated #259 to reflect the license question.
There was a problem hiding this comment.
There was
- Extend the
nightly_modelslist with the given model and run nightly tests for that model: https://github.com/openvinotoolkit/openvino.genai/tree/master/tests/python_tests#customise-tests-run. Report if there are failing tests and comment out the model in thenightly_modelslist. Add this change to your pull request (PR).
recently added. Please do that after MiniCPM-2B-dpo-fp16 gets a compatible license.
|
hey @pohsengl will you find a time to update a PR, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should close #261, I have updated the model list, and added tests taking reference from issue description at #259.
@Wovchena, Please let me know if there is any changes needed. Thanks!