Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--base-wallet-routes flag no longer works #3283

Closed
dbluhm opened this issue Oct 11, 2024 · 4 comments · Fixed by #3344
Closed

--base-wallet-routes flag no longer works #3283

dbluhm opened this issue Oct 11, 2024 · 4 comments · Fixed by #3344
Assignees

Comments

@dbluhm
Copy link
Contributor

dbluhm commented Oct 11, 2024

After the swap to using decorators to delineate routes accessible by tenants and routes accessible by admins, the ability to grant access to the base wallet to additional routes was lost.

This option made it possible for a base wallet to form a didcomm connection with a mediator and then use that as a base mediator for all tenants, among other things.

cc @esune @jamshale

@jamshale
Copy link
Contributor

jamshale commented Oct 11, 2024

So many configs... Guess the flag wasn't tested. I'll wait and see if Emiliano knows an easy way to fix it.

@dbluhm
Copy link
Contributor Author

dbluhm commented Oct 11, 2024

Yeah, indeed, I only just detected this myself.

@esune
Copy link
Member

esune commented Oct 11, 2024

I didn't even know this setting/option existed 😅. My understanding was that the base wallet would always ONLY deal with tenant provisioning tasks and nothing else, so the decorators were set-up to function this way.

That being said, I think we would have to move this logic into the tenant_authentication decorator for things to work.

Adding a separate decorator just for this would be also an option and it would be more explicit, however the fact that we'd have to basically blanket apply it everywhere AND, more importantly, the added complexity of having multiple decorators stacked (in the right order) makes me think it is actually not the best option.

@esune esune self-assigned this Nov 19, 2024
@esune
Copy link
Member

esune commented Nov 19, 2024

Taking a stab at this since it was brought up at today's maintainers meeting

@esune esune moved this to Assigned in CDT Enterprise Apps Nov 19, 2024
@esune esune moved this from Assigned to In Review in CDT Enterprise Apps Nov 21, 2024
@github-project-automation github-project-automation bot moved this from In Review to Complete in CDT Enterprise Apps Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants