Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Added command line utility to export users #355 #356

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

pandafy
Copy link
Member

@pandafy pandafy commented Jul 26, 2023

Closes #355

@pandafy pandafy force-pushed the issues/355-command-line-utility branch from 5df56d8 to 829b12a Compare July 26, 2023 15:14
@coveralls
Copy link

coveralls commented Jul 26, 2023

Coverage Status

coverage: 97.77% (-0.07%) from 97.84% when pulling 20d217c on issues/355-command-line-utility into 84ac9fd on master.

Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the test coverage here?

@pandafy pandafy force-pushed the issues/355-command-line-utility branch 2 times, most recently from a20759d to d76355c Compare July 31, 2023 20:11
@pandafy pandafy force-pushed the issues/355-command-line-utility branch from d76355c to b026b2b Compare July 31, 2023 20:20
README.rst Outdated
**Arguments**:

- `--exclude-fields`: Comma-separated list of fields to exclude from the export.
- `--filename`: Filename for the exported CSV, defaults to "openwisp_exported_users.csv".
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide an example with the arguments, eg:

./manage.py export_users
 --filename export-excluded-pwd-id.csv --exclude-fields password,id

README.rst Outdated
- `--filename`: Filename for the exported CSV, defaults to "openwisp_exported_users.csv".

You can change the exported fields using the `OPENWISP_USERS_EXPORT_USERS_COMMAND_CONFIG
<#openwisp_users_export_users_command_config>`_ setting.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure I understand the point of this since users can use the --exclude-fields flag.
I think it's worth to point out that this setting is meant to be used for advanced customizations.

@nemesifier nemesifier merged commit 8403e5a into master Aug 17, 2023
10 checks passed
@nemesifier nemesifier deleted the issues/355-command-line-utility branch August 17, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Command line tool to export users data
3 participants