Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: read index.json for snapshot package feeds #1080

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

efahl
Copy link
Contributor

@efahl efahl commented Nov 12, 2024

As of the apk switchover, the Packages file no longer is created as part of the package feeds. Instead, utilize the index.json file created from apk's packages.db.

See openwrt/openwrt@f841870

As of the apk switchover, the Packages file no longer is created as part of
the package feeds.  Instead, utilize the index.json file created from apk's
packages.db.

See openwrt/openwrt@f841870

Signed-off-by: Eric Fahlgren <ericfahlgren@gmail.com>
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 90.39%. Comparing base (5e65dec) to head (8e65fef).
Report is 149 commits behind head on main.

Files with missing lines Patch % Lines
asu/main.py 0.00% 4 Missing ⚠️
asu/util.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1080      +/-   ##
==========================================
+ Coverage   80.75%   90.39%   +9.63%     
==========================================
  Files          15       14       -1     
  Lines         977     1114     +137     
==========================================
+ Hits          789     1007     +218     
+ Misses        188      107      -81     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aparcar
Copy link
Member

aparcar commented Nov 12, 2024

Some time ago I implemented this to always try index.json first and fallback to Packages if not available. I think the issue with the your approach was something with the ABI version, did you check for that?

@efahl
Copy link
Contributor Author

efahl commented Nov 12, 2024

Yeah, the ABI versioned names are currently present in the index.json files (which is why I restricted this to use index.json for snapshots, and Packages for all the "old" builds). @Ansuel and I have discussed the ABI issue a bit on the forum, but it's an upstream issue and this gets the pipeline in place for the APK builds. Once ABI-ed names issue gets resolved upstream, this should work without modification.

@aparcar aparcar merged commit 11e121c into openwrt:main Nov 13, 2024
3 of 4 checks passed
@efahl efahl deleted the use-package-index-json branch November 13, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants