Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the API for diagnostic requests to be more obvious #180

Open
peplin opened this issue Sep 7, 2014 · 0 comments
Open

Refactor the API for diagnostic requests to be more obvious #180

peplin opened this issue Sep 7, 2014 · 0 comments
Labels
future work Issues that are not high on the priority list. ready

Comments

@peplin
Copy link
Member

peplin commented Sep 7, 2014

If you pass a DiagnosticRequest to VehicleManager.send(...), it will wrap that in a CommandMessage and set the action field to ADD. If you want to cancel a diagnostic request, you have to build your own Command and set the action to CANCEL.

That seems OK, but then the API gets confused - if you pass a Command with a DiagnosticRequest inside to VehicleManager.request(...), it won't set up the correct listener. It'll be looking for a command response instead of a diagnostic response.

@peplin peplin added the ready label Sep 7, 2014
@peplin peplin changed the title Support CANCEL action for diagnostic requests Refactor the API for diagnostic requests to be more obvious Nov 2, 2014
@alokonly alokonly added the future work Issues that are not high on the priority list. label Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
future work Issues that are not high on the priority list. ready
Projects
None yet
Development

No branches or pull requests

2 participants